[Relay] Make check stricter by using Feature. Fixed multiple bugs. #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarisaKirisame
force-pushed
the
stricter-pe
branch
from
0a02749
to
9cea77a
Compare
MarisaKirisame
force-pushed
the
stricter-pe
branch
from
3816196
to
fff05bd
Compare
|
Please ping me when this PR is ready for review :-) |
|
@junrushao1994 it is. I am trying to fix the ci though. |
junrushao
reviewed
Aug 24, 2020
include/tvm/relay/feature.h
Outdated
| * | ||
| * \return a string representation. | ||
| */ | ||
| std::string Print() const; |
There was a problem hiding this comment.
Maybe ToString sounds better?
| test_pattern_with_check() | ||
| test_diamond_not_merge() | ||
| test_type_check() | ||
| #pytest.main([__file__]) |
junrushao
approved these changes
Aug 25, 2020
MarisaKirisame
changed the title
jroesch
approved these changes
Aug 25, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6326) * save lint lint lint fix lint lint update lint save save save lint format format save save fix use a form more suitable for numeric check save * save * save * lint * save * lint * fix * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6326) * save lint lint lint fix lint lint update lint save save save lint format format save save fix use a form more suitable for numeric check save * save * save * lint * save * lint * fix * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6326) * save lint lint lint fix lint lint update lint save save save lint format format save save fix use a form more suitable for numeric check save * save * save * lint * save * lint * fix * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…pache#6326) * save lint lint lint fix lint lint update lint save save save lint format format save save fix use a form more suitable for numeric check save * save * save * lint * save * lint * fix * fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…pache#6326) * save lint lint lint fix lint lint update lint save save save lint format format save save fix use a form more suitable for numeric check save * save * save * lint * save * lint * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
@jroesch @junrushao1994 @zhiics please help review.
Also, do anyone know why test_pass_merge_composite suddenly failed? I hadnt touched any of the files, and it shouldnt call CPS/PE/AD.