[tvmc] linting error on onnx command line driver frontend #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
changed the title
mbaret
reviewed
Sep 23, 2020
mbaret
approved these changes
Sep 23, 2020
manupak
approved these changes
Sep 23, 2020
|
also cc @tqchen to merge, in case you agree with this change. |
|
From the ONNX package |
comaniac
changed the title
Yeah, looking at it again, it makes sense to come back to
This is the main reason for this PR. If I get a fresh clone from github and run
Will move it back. |
tqchen
approved these changes
Sep 23, 2020
* Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
comaniac
approved these changes
Sep 23, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
…che#6536) * Updates onnx load function from "load" (a compatibility attribute) to "load_model" (the actual function) * Add a pylint command, that we don't see currently on upstream CI, but it reproduces when linting it locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor changes on
tvmc:cc @manupa-arm @comaniac @d-smirnov