Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][DataProxy] Optimize the log output in the Sink module #8294

Closed
2 tasks done
gosonzhang opened this issue Jun 20, 2023 · 0 comments · Fixed by #8295
Closed
2 tasks done

[Improve][DataProxy] Optimize the log output in the Sink module #8294

gosonzhang opened this issue Jun 20, 2023 · 0 comments · Fixed by #8295
Assignees
@gosonzhang
Labels
component/dataproxy type/improve
Milestone
1.8.0

Comments

@gosonzhang
Copy link
Contributor

Description

There are several problems with the log output under the Sink module:

  1. It is not necessary to set the scope of the log object Public, and it is more appropriate to define it as private or protected;
  2. The content of the log output is not very clear, and it is impossible to locate which Sink object generated the content;
  3. The operation encapsulation of some objects is not very good, it is better to use the function method;
  4. Part of the code is not used and needs to be removed

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosonzhang gosonzhang

Labels
component/dataproxy type/improve
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

[INLONG-8294][DataProxy] Optimize the log output in the Sink module
1 participant
@gosonzhang