Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Manager] StartupSortListener may miss to build flink job for every stream #9632

Closed
2 tasks done
aloyszhang opened this issue Jan 30, 2024 · 0 comments · Fixed by #9633
Closed
2 tasks done

[Bug][Manager] StartupSortListener may miss to build flink job for every stream #9632

aloyszhang opened this issue Jan 30, 2024 · 0 comments · Fixed by #9633
Labels
type/bug Something is wrong
Milestone

Comments

@aloyszhang
Copy link
Contributor

What happened

If a multi-streams group has a stream with an empty sinkList(or has no SortFlink type sink), the following streams will be skipped.
https://github.com/apache/inlong/blob/master/inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/listener/StartupSortListener.java#L100~L105

 for (InlongStreamInfo streamInfo : streamInfos) {
            List<StreamSink> sinkList = streamInfo.getSinkList();
            List<String> sinkTypes = sinkList.stream().map(StreamSink::getSinkType).collect(Collectors.toList());
            if (CollectionUtils.isEmpty(sinkList) || !SinkType.containSortFlinkSink(sinkTypes)) {
                return ListenerResult.success();
            }

What you expected to happen

All streams should not be skipped.

How to reproduce

No need to reproduce

Environment

No response

InLong version

master

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant