Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all unused-return-value warnings for Status #1196

Closed
1 of 2 tasks
PragmaTwice opened this issue Dec 18, 2022 · 0 comments · Fixed by #1214
Closed
1 of 2 tasks

Fix all unused-return-value warnings for Status #1196

PragmaTwice opened this issue Dec 18, 2022 · 0 comments · Fixed by #1214
Labels
enhancement type enhancement

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

After #1193, we have lots of warnings in building kvrocks, since some of code discard the return value of Status or StatusOr.

We need fix them all, and then make it a compile error instead of a warning.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement type enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring: check function return Status marked as [[nodiscard]] torwig/kvrocks
1 participant
@PragmaTwice