For the expired key, the TYPE command returns dirty data

[jjz921024]

Search before asking

• I had searched in the issues and found no similar issues.

Version

kvrocks v2.3.0

Minimal reproduce step

127.0.0.1:31001> set k v ex 10
OK
127.0.0.1:31001> type k
"string"
127.0.0.1:31001> ttl k
(integer) 3
127.0.0.1:31001> ttl k
(integer) -2
127.0.0.1:31001> type k
"string"
127.0.0.1:31001> get k
(nil)
127.0.0.1:31001> type k
"string"

What did you expect to see?

None should been returned for the expired key

What did you see instead?

For the expired key, the TYPE command returns dirty data

Anything Else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[git-hulk]

@jjz921024 Thanks for your good catch.

[ghost]

rocksdb has a feature whereby an expired key is not removed immediately but during compaction. If the size of a specific level is not large enough to trigger compaction, the old data remains. Compacting manually is one possible solution, but it may cause write stalls

[git-hulk]

Hi @Lericaro

This bug was caused by the type command didn't check the expiry time, and it's OK to recycle those expired items later by compaction.