Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support of the BZMPOP command #1445

Closed
1 of 5 tasks
infdahai opened this issue May 18, 2023 · 14 comments · Fixed by #1490
Closed
1 of 5 tasks

Add the support of the BZMPOP command #1445

infdahai opened this issue May 18, 2023 · 14 comments · Fixed by #1490
Labels
enhancement type enhancement

Comments

@infdahai
Copy link
Contributor

infdahai commented May 18, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

This issue considers to support bzmpop, bzpopmax, bzpopmin commands.

And the implementation should process a timeout argument.

Solution

  • bzmpop
  • bzpopmax
  • bzpopmin

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@infdahai infdahai added the enhancement type enhancement label May 18, 2023
@git-hulk
Copy link
Member

@infdahai Would you like to do this?

@infdahai
Copy link
Contributor Author

infdahai commented May 19, 2023

I can accept this task for now but it needs time.

And more specifically, I want to use bzpop<max|min|null>, <z|s>intercard, zmpop go APIs to write some go-unit tests for supporting the more commands from zset or set in kvrocks. These commands from redis(version >= 6.2) are not implemented in this project.

Because I want to implement all commands from zset. If anyone wants to get involved in this task, you can just reply under this issue.

@infdahai infdahai changed the title Add support of the BZMPOP command Add the support of the BZMPOP command May 21, 2023
@Yangsx-1
Copy link
Contributor

I want to participate in the task, can i contact you through wechat or other ways?

@infdahai
Copy link
Contributor Author

infdahai commented May 26, 2023

@git-hulk please invite him to wechat groups. Mabye you can search the TimerCB funcs in the codebase to learn how to add the event to the loop. And we can talk the impl here to help others also know the progress.

@git-hulk
Copy link
Member

Please follow the WeChat Official Account at the bottom of README.md, then join the WeChat group via the guidance.

But we encourage everyone to discuss the proposal or solution via GitHub Discussion instead of a private channel.

@Yangsx-1
Copy link
Contributor

Ok, I'm already in the group and i'll look into the code. I’m new in here, may i'll have many questions, lol.

@Yangsx-1
Copy link
Contributor

Yangsx-1 commented Jun 7, 2023

I think it's bzpopmax rather than bzmpopmax.

@infdahai
Copy link
Contributor Author

infdahai commented Jun 7, 2023

I think it's bzpopmax rather than bzmpopmax.

Thanks, fixed

@PragmaTwice
Copy link
Member

PragmaTwice commented Jun 7, 2023

Note: As an ASF community, we do not endorse any discussion on some private channels like wechat group.

We prefer public available discussion like GitHub issues, discussions and ASF mailing lists. Feel free to post your questions on these platform.

@Yangsx-1
Copy link
Contributor

Yangsx-1 commented Jun 7, 2023

Note: As an ASF community, we do not endorse any discussion on some private channels like wechat group.

We prefer public available discussion like GitHub issues, discussions and ASF mailing lists. Feel free to post your questions on these platform.

Ok, i'm just a little shy. I'll post my question if i cannot overcome it.

@Yangsx-1
Copy link
Contributor

Yangsx-1 commented Jun 9, 2023

I‘ve already finish the code, and have tested it manually.
I'm now trying to add some go tests but i'm not very familiar with go and go test.
I want to know how to run single test for zset, i tried several ways but it didn't work. :(

@git-hulk
Copy link
Member

git-hulk commented Jun 9, 2023

I‘ve already finish the code, and have tested it manually. I'm now trying to add some go tests but i'm not very familiar with go and go test. I want to know how to run single test for zset, i tried several ways but it didn't work. :(

Hi @Yangsx-1, You can reach me on Slack if you need help.

@PragmaTwice
Copy link
Member

I‘ve already finish the code, and have tested it manually.
I'm now trying to add some go tests but i'm not very familiar with go and go test.
I want to know how to run single test for zset, i tried several ways but it didn't work. :(

Try something like ./x.py test go <build-dir> -run <match-str>.

And you can refer to go test --help for more information about the -run option.

@Yangsx-1
Copy link
Contributor

Yangsx-1 commented Jun 9, 2023

Ok, I'll try it first. I'll contact you if i have some problems later @git-hulk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants