-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the support of the BZMPOP
command
#1445
Comments
@infdahai Would you like to do this? |
I can accept this task for now but it needs time.
Because I want to implement all commands from |
BZMPOP
commandBZMPOP
command
I want to participate in the task, can i contact you through wechat or other ways? |
@git-hulk please invite him to wechat groups. Mabye you can search the TimerCB funcs in the codebase to learn how to add the event to the loop. And we can talk the impl here to help others also know the progress. |
Please follow the WeChat Official Account at the bottom of README.md, then join the WeChat group via the guidance. But we encourage everyone to discuss the proposal or solution via GitHub Discussion instead of a private channel. |
Ok, I'm already in the group and i'll look into the code. I’m new in here, may i'll have many questions, lol. |
I think it's bzpopmax rather than bzmpopmax. |
Thanks, fixed |
Note: As an ASF community, we do not endorse any discussion on some private channels like wechat group. We prefer public available discussion like GitHub issues, discussions and ASF mailing lists. Feel free to post your questions on these platform. |
Ok, i'm just a little shy. I'll post my question if i cannot overcome it. |
I‘ve already finish the code, and have tested it manually. |
Hi @Yangsx-1, You can reach me on Slack if you need help. |
Try something like And you can refer to |
Ok, I'll try it first. I'll contact you if i have some problems later @git-hulk |
Search before asking
Motivation
This issue considers to support
bzmpop
,bzpopmax
,bzpopmin
commands.And the implementation should process a
timeout
argument.Solution
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: