Command SRANDMEMBER returns empty array when [count] is a negative number

[sam-hn]

Search before asking

• I had searched in the issues and found no similar issues.

Version

2.7.0

Minimal reproduce step

10.70.163.45:6666> srandmember set1 5

1. "mem1"
2. "mem2"
3. "mem3"
   10.70.163.45:6666> srandmember set1 -5
   (empty array)
   10.70.163.45:6666> srandmember set1 -2
   (empty array)

What did you expect to see?

According to https://redis.io/commands/srandmember/, If called with a negative count, the behavior changes and the command is allowed to return the same element multiple times. In this case, the number of returned elements is the absolute value of the specified count

What did you see instead?

Anything Else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[jihuayu]

@sam-hn Thank you.
You can find related code in this
And it is better if you can add a test case

[git-hulk]

It has been resolved in #2032?

[jihuayu]

@git-hulk It looks like no. First is Redis, second is kvrocks

[mapleFU]

rocksdb::Status Set::Take(const Slice &user_key, std::vector<std::string> *members, int count, bool pop) {
  int n = 0;
  members->clear();
  if (count <= 0) return rocksdb::Status::OK();

The problem it's the 4th line... It would be easy to fix

[git-hulk]

@git-hulk It looks like no. First is Redis, second is kvrocks

Got it, thank you!

[mapleFU]

I've fixed this via: #2113