Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate incremental data via parsing and filtering data #657

Closed
Tracked by #647
tisonkun opened this issue Jun 24, 2022 · 6 comments · Fixed by #666
Closed
Tracked by #647

Migrate incremental data via parsing and filtering data #657

tisonkun opened this issue Jun 24, 2022 · 6 comments · Fixed by #666

Comments

@tisonkun
Copy link
Member

tisonkun commented Jun 24, 2022

Report https://github.com/apache/incubator-kvrocks/runs/7034653085?check_suite_focus=true#step:10:687

@git-hulk
Copy link
Member

This test case spent almost 30s on my local machine and it should be even slower in CI environment. So we can increase the wait time from 50s => 100s if has no idea. Do guys
have any thoughts about this case? @ChrisZMF @ShooterIT @caipengbo

@tisonkun
Copy link
Member Author

It's a valid workaround. However, it's better to make the waiting determinately - is it possible?

@git-hulk
Copy link
Member

It's a valid workaround. However, it's better to make the waiting determinately - is it possible?

Yes, can check the migrate finished status which we're doing at line: slotmigrate.tcl#L513, we can remove the time limit.

@git-hulk
Copy link
Member

@tisonkun removed the time limit, can help to take a look again.

@caipengbo
Copy link
Contributor

Is there any way we can reduce the waiting time?  I think this test case is taking too long.

@git-hulk
Copy link
Member

Maybe we can test whether increase the pipeline size can help or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants