-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rocksdb ops by COMMAND INFO in tests/unit/command.tcl [expr abs($cmd_qps - $put_qps)] < 10 #658
Comments
Let me track this problem. |
@caipengbo I took a look at this test case and those metrics would be affected by other test cases, maybe we should change the test case to avoid that. |
Yeah, it should be the effect of previous OPS, how about wait a little longer to let QPS empty? @git-hulk |
Another workaround can be also fetching those metrics before running |
I looked again, and it didn't seem to be the influence of the previous OPS; I took a look at this failed case:https://github.com/apache/incubator-kvrocks/runs/6453256361?check_suite_focus=true#step:7:2018, it show only 432 OPS. But theoretically, OPS should be 1000, the gap is too large. My guess is that tcl |
It's expected since we used time based metrics instead of counter: https://github.com/apache/incubator-kvrocks/blob/0b2de8ab6f661d90a279a0c11096755d7733b11c/src/stats.cc#L108 So ops can be affected by the elapsed time, I think it's too long instead of too short? |
Report: https://github.com/apache/incubator-kvrocks/runs/6453256361?check_suite_focus=true#step:7:2018
The text was updated successfully, but these errors were encountered: