Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak reports in tcl test cases #702

Closed
1 of 2 tasks
git-hulk opened this issue Jul 1, 2022 · 2 comments
Closed
1 of 2 tasks

Memory leak reports in tcl test cases #702

git-hulk opened this issue Jul 1, 2022 · 2 comments
Labels
bug type bug

Comments

@git-hulk
Copy link
Member

git-hulk commented Jul 1, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Version

unstable

Minimal reproduce step

$ ./build.sh build -DENABLE_ASAN=ON
$ cd tests/tcl
$ ./runtest --dont-clean

What did you expect to see?

No memory leak reported

What did you see instead?

https://github.com/apache/incubator-kvrocks/runs/7133747333?check_suite_focus=true

=================================================================
==30270==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1023 byte(s) in 1 object(s) allocated from:
    #0 0x7f0b2c2e5b40 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb40)
    #1 0x55ef1f258c72 in strbuf_init (/home/runner/work/incubator-kvrocks/incubator-kvrocks/tests/tcl/redis-server+0xa1ec72)

Anything Else?

I noticed only the cjson library is using strbuf_init.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@git-hulk git-hulk added the bug type bug label Jul 1, 2022
@tisonkun
Copy link
Member

tisonkun commented Jul 1, 2022

@git-hulk is it an issue on unstable branch or #697 only? We shouldn't create issue for further problem. It seems we may fix this issue at KvrocksLabs/luajit aspect?

In another word, I don't see what we can do before #697 merged and on unstable branch.

@git-hulk
Copy link
Member Author

git-hulk commented Jul 1, 2022

@git-hulk is it an issue on unstable branch or #697 only? We shouldn't create issue for further problem. It seems we may fix this issue at KvrocksLabs/luajit aspect?

In another word, I don't see what we can do before #697 merged and on unstable branch.

My bad. I think the Lua library is using cjson, so it should have the same problem as well. Will close this issue since it looks introduced by #697 and have an eye on this case.

@git-hulk git-hulk closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

No branches or pull requests

2 participants