Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for new command parsing framework #794

Closed
2 tasks done
PragmaTwice opened this issue Aug 27, 2022 · 1 comment
Closed
2 tasks done

Tracking issue for new command parsing framework #794

PragmaTwice opened this issue Aug 27, 2022 · 1 comment
Labels
enhancement type enhancement

Comments

@PragmaTwice
Copy link
Member

PragmaTwice commented Aug 27, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

In kvrocks, command parsing is currently done by some primitive array operations, which works fine for simple commands, but when command parsing rules become complex, the code becomes extremely difficult to understand and maintain. In addition, the parsing of data values such as numerics and enumerations is not well encapsulated.

This work was originally described in #598 to provide an easy-to-use parsing framework for parsing redis commands, especially complex redis commands. In addition, another goal of this work is to eliminate redundant string copies, which are currently widespread in kvrocks, and we will try to introduce something like std::string_view or design APIs that make better use of move semantics of std::string.

Solution

working PRs:

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@PragmaTwice PragmaTwice added the enhancement type enhancement label Aug 27, 2022
@git-hulk
Copy link
Member

Many thanks for @PragmaTwice bringing those awesome features to the community.

@PragmaTwice PragmaTwice changed the title New command parsing framework Tracing new command parsing framework Aug 29, 2022
@PragmaTwice PragmaTwice changed the title Tracing new command parsing framework Tracking issue for new command parsing framework Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

2 participants