Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Go cases into build scripts #813

Closed
Tracked by #811
tisonkun opened this issue Sep 4, 2022 · 3 comments
Closed
Tracked by #811

Integrate Go cases into build scripts #813

tisonkun opened this issue Sep 4, 2022 · 3 comments
Labels
enhancement type enhancement help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

tisonkun commented Sep 4, 2022

I think basically we can treat Go cases as a standalone module and write a Makefile to it for running linters and tests.

Then we wire it into the x.py script.

@PragmaTwice
Copy link
Member

PragmaTwice commented Sep 7, 2022

I am thinking whether the makefile is necessary, since it is just a test module and we already have x.py which is a general script for developers.

If there are two scripts that need to be maintained, I think it might cause some confusion. The functionality of the makefile is not orthogonal to our current x.py, they have similiar capabilities.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

@PragmaTwice you're right. Previously I'm thinking of adding linters for Go code and then build/test can depend on the lint task. Makefile does a good job for task dependencies while implementing it inside a script is awkward. However, now I believe we can run lint in another x.py command and there's no dependency between tasks to handle. So your patch is great.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

Closed by #832.

@tisonkun tisonkun closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants