Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TCL test unit/type/set to Go case #819

Closed
Tracked by #811
tisonkun opened this issue Sep 4, 2022 · 5 comments · Fixed by #858
Closed
Tracked by #811

Move TCL test unit/type/set to Go case #819

tisonkun opened this issue Sep 4, 2022 · 5 comments · Fixed by #858
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

tisonkun commented Sep 4, 2022

No description provided.

@tisonkun tisonkun added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Sep 4, 2022
@tanruixiang
Copy link
Member

I'd like to do this.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 9, 2022

@tanruixiang Assigned. Go ahead!

@tanruixiang
Copy link
Member

tanruixiang commented Sep 10, 2022

Hi. I'm not very familiar with go. How to use go to pass the value exceeding Int64 in int ?Do we just need to pass it in the form of a string(I found that kvrocks should not implement large numbers, and automatically convert this to a string)?

    test "SADD an integer larger than 64 bits" {
        create_set myset {213244124402402314402033402}
        #assert_encoding hashtable myset
        assert_equal 1 [r sismember myset 213244124402402314402033402]
        assert_equal {1} [r smismember myset 213244124402402314402033402]
    }

@PragmaTwice
Copy link
Member

PragmaTwice commented Sep 10, 2022

Hi. I'm not very familiar with go. How to use go to pass the value exceeding Int64 in int ?Do we just need to pass it in the form of a string(I found that kvrocks should not implement large numbers, and automatically convert this to a string)?

    test "SADD an integer larger than 64 bits" {
        create_set myset {213244124402402314402033402}
        #assert_encoding hashtable myset
        assert_equal 1 [r sismember myset 213244124402402314402033402]
        assert_equal {1} [r smismember myset 213244124402402314402033402]
    }

I think maybe there is no difference between string and integer here, i.e. you can use string here. cc @git-hulk

@git-hulk
Copy link
Member

Hi. I'm not very familiar with go. How to use go to pass the value exceeding Int64 in int ?Do we just need to pass it in the form of a string(I found that kvrocks should not implement large numbers, and automatically convert this to a string)?

    test "SADD an integer larger than 64 bits" {
        create_set myset {213244124402402314402033402}
        #assert_encoding hashtable myset
        assert_equal 1 [r sismember myset 213244124402402314402033402]
        assert_equal {1} [r smismember myset 213244124402402314402033402]
    }

I think maybe there is no difference between string and integer here, i.e. you can use string here. cc @git-hulk

Yes, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants