Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TCL test unit/scripting to Go case #872

Closed
Tracked by #811
tisonkun opened this issue Sep 13, 2022 · 7 comments · Fixed by #900
Closed
Tracked by #811

Move TCL test unit/scripting to Go case #872

tisonkun opened this issue Sep 13, 2022 · 7 comments · Fixed by #900
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

tisonkun commented Sep 13, 2022

Be aware that current scripting tests are unstable. See also #867.

@tanruixiang
Copy link
Member

list_test.go is also unstable.

@tisonkun
Copy link
Member Author

@tanruixiang can you provide run reports?

@tisonkun
Copy link
Member Author

OK I see it.

@tisonkun
Copy link
Member Author

@vmihailenco it seems after Kvrocks tests migrated to go-redis, some cases fail with:

    list_test.go:203: 
        	Error Trace:	/home/runner/work/incubator-kvrocks/incubator-kvrocks/tests/gocase/unit/type/list/list_test.go:203
        	Error:      	Received unexpected error:
        	            	read tcp 127.0.0.1:55526->127.0.0.1:45695: i/o timeout
        	Test:       	TestZipList/ziplist_implementation:_value_encoding_and_backlink

when under stress. What's the best practice go-redis retry to set up a reasonable timeout in this case?

@vmihailenco
Copy link

There is a MaxRetries options and it seems to be enabled by default - https://github.com/go-redis/redis/blob/master/options.go#L61-L69

What Read/WriteTimeout do you use?

@tisonkun
Copy link
Member Author

@vmihailenco I think the first time we even disable retry #869 to try to address this flaky test. The reason then is we may reduce the workload caused by retries. But it seems we need to extend the retry time and timeout interval. However, always increasing waiting interval and retry time seems not a good idea...

Would you suggest a suitable config here?

@vmihailenco
Copy link

Would you suggest a suitable config here?

Looks like you are using the default config which has Read/WriteTimeout = 3 seconds. It should work just fine, but you can try to increase the timeout. Nothing else comes to mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants