-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TCL test unit/scripting to Go case #872
Comments
list_test.go is also unstable. |
@tanruixiang can you provide run reports? |
OK I see it. |
@vmihailenco it seems after Kvrocks tests migrated to go-redis, some cases fail with:
when under stress. What's the best practice go-redis retry to set up a reasonable timeout in this case? |
There is a What Read/WriteTimeout do you use? |
@vmihailenco I think the first time we even disable retry #869 to try to address this flaky test. The reason then is we may reduce the workload caused by retries. But it seems we need to extend the retry time and timeout interval. However, always increasing waiting interval and retry time seems not a good idea... Would you suggest a suitable config here? |
Looks like you are using the default config which has Read/WriteTimeout = 3 seconds. It should work just fine, but you can try to increase the timeout. Nothing else comes to mind. |
Be aware that current scripting tests are unstable. See also #867.
The text was updated successfully, but these errors were encountered: