Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PING returns PONG if no argument is provided, otherwise return a copy of the argument as a bulk. #926

Closed
2 tasks done
ColinChamber opened this issue Sep 28, 2022 · 2 comments · Fixed by #933
Closed
2 tasks done
Labels
bug type bug

Comments

@ColinChamber
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Version

unstable

Minimal reproduce step

ping message

What did you expect to see?

message

What did you see instead?

wrong number of arguments

Anything Else?

redis ping

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@ColinChamber ColinChamber added the bug type bug label Sep 28, 2022
@git-hulk
Copy link
Member

wow, it refreshes my knowledge.😃

@ColinChamber
Copy link
Contributor Author

I haven't used Kvrocks for a long time. I can only do some boring PR first. 😃 However, there are indeed applications that add parameters to ping, such as celery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants