Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] kvrocks2redis should not lowercase all lines when reading configuration files #964

Closed
2 tasks done
manchurio opened this issue Oct 9, 2022 · 1 comment · Fixed by #971
Closed
2 tasks done

[bug] kvrocks2redis should not lowercase all lines when reading configuration files #964

manchurio opened this issue Oct 9, 2022 · 1 comment · Fixed by #971
Labels
bug type bug

Comments

@manchurio
Copy link
Contributor

manchurio commented Oct 9, 2022 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Version

image

Cannot connect to the server when the password contains uppercase letters

Minimal reproduce step

# kvrocks <kvrocks_ip> <kvrocks_port> [<kvrocks_auth>]
kvrocks 127.0.0.1 6666 Pass

What did you expect to see?

connect to the server successfully

What did you see instead?

invalid password

Anything Else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@manchurio manchurio added the bug type bug label Oct 9, 2022
@torwig
Copy link
Contributor

torwig commented Oct 9, 2022

@manchurio Good catch!

@manchurio manchurio mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug type bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep password case-sensitive in kvrocks2redis manchurio/kvrocks
2 participants
@torwig @manchurio