Skip to content

Commit 2dad761

Browse files
authored
Merge branch 'apache:master' into master
2 parents 46725f0 + c09cd65 commit 2dad761

File tree

5 files changed

+63
-14
lines changed

5 files changed

+63
-14
lines changed

dev/dependencyList

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ jakarta.ws.rs-api/2.1.6//jakarta.ws.rs-api-2.1.6.jar
5252
jakarta.xml.bind-api/2.3.2//jakarta.xml.bind-api-2.3.2.jar
5353
javassist/3.25.0-GA//javassist-3.25.0-GA.jar
5454
jcl-over-slf4j/1.7.35//jcl-over-slf4j-1.7.35.jar
55-
jersey-client/2.34//jersey-client-2.34.jar
56-
jersey-common/2.34//jersey-common-2.34.jar
57-
jersey-container-servlet-core/2.34//jersey-container-servlet-core-2.34.jar
58-
jersey-entity-filtering/2.34//jersey-entity-filtering-2.34.jar
59-
jersey-hk2/2.34//jersey-hk2-2.34.jar
60-
jersey-media-json-jackson/2.34//jersey-media-json-jackson-2.34.jar
61-
jersey-server/2.34//jersey-server-2.34.jar
55+
jersey-client/2.35//jersey-client-2.35.jar
56+
jersey-common/2.35//jersey-common-2.35.jar
57+
jersey-container-servlet-core/2.35//jersey-container-servlet-core-2.35.jar
58+
jersey-entity-filtering/2.35//jersey-entity-filtering-2.35.jar
59+
jersey-hk2/2.35//jersey-hk2-2.35.jar
60+
jersey-media-json-jackson/2.35//jersey-media-json-jackson-2.35.jar
61+
jersey-server/2.35//jersey-server-2.35.jar
6262
jetty-http/9.4.41.v20210516//jetty-http-9.4.41.v20210516.jar
6363
jetty-io/9.4.41.v20210516//jetty-io-9.4.41.v20210516.jar
6464
jetty-security/9.4.41.v20210516//jetty-security-9.4.41.v20210516.jar

externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ import scala.collection.JavaConverters._
2626
import scala.collection.mutable.ListBuffer
2727

2828
import org.apache.flink.client.cli.{CliFrontend, CustomCommandLine, DefaultCLI, GenericCLI}
29-
import org.apache.flink.configuration.DeploymentOptions
30-
import org.apache.flink.configuration.GlobalConfiguration
29+
import org.apache.flink.configuration.{Configuration, DeploymentOptions, GlobalConfiguration}
3130
import org.apache.flink.table.client.SqlClientException
3231
import org.apache.flink.table.client.gateway.context.DefaultContext
3332
import org.apache.flink.util.JarUtils
@@ -77,6 +76,8 @@ object FlinkSQLEngine extends Logging {
7776
try {
7877
val flinkConfDir = CliFrontend.getConfigurationDirectoryFromEnv
7978
val flinkConf = GlobalConfiguration.loadConfiguration(flinkConfDir)
79+
val flinkConfFromKyuubi = kyuubiConf.getAllWithPrefix("flink", "")
80+
flinkConf.addAll(Configuration.fromMap(flinkConfFromKyuubi.asJava))
8081

8182
val executionTarget = flinkConf.getString(DeploymentOptions.TARGET)
8283
// set cluster name for per-job and application mode
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
package org.apache.kyuubi.it.flink
19+
20+
import org.apache.kyuubi.config.KyuubiConf
21+
import org.apache.kyuubi.config.KyuubiConf.{ENGINE_TYPE, FRONTEND_THRIFT_BINARY_BIND_PORT}
22+
import org.apache.kyuubi.operation.HiveJDBCTestHelper
23+
24+
class FlinkSQLEngineSuite extends WithKyuubiServerAndFlinkMiniCluster with HiveJDBCTestHelper {
25+
26+
override val conf: KyuubiConf = KyuubiConf()
27+
.set(ENGINE_TYPE, "FLINK_SQL")
28+
.set(FRONTEND_THRIFT_BINARY_BIND_PORT, 10029)
29+
.set("flink.parallelism.default", "6")
30+
31+
override protected def jdbcUrl: String = getJdbcUrl
32+
33+
test("set kyuubi conf into flink conf") {
34+
withJdbcStatement() { statement =>
35+
val resultSet = statement.executeQuery("SET")
36+
// Flink does not support set key without value currently,
37+
// thus read all rows to find the desired one
38+
var success = false
39+
while (resultSet.next() && success == false) {
40+
if (resultSet.getString(1) == "parallelism.default" &&
41+
resultSet.getString(2) == "6") {
42+
success = true
43+
}
44+
}
45+
assert(success)
46+
}
47+
}
48+
}

kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,13 @@ private[kyuubi] class EngineRef(
123123
* The EngineSpace used to expose itself to the KyuubiServers in `serverSpace`
124124
*
125125
* For `CONNECTION` share level:
126-
* /`serverSpace_CONNECTION_engineType`/`user`/`engineRefId`
126+
* /`serverSpace_version_CONNECTION_engineType`/`user`/`engineRefId`
127127
* For `USER` share level:
128-
* /`serverSpace_USER_engineType`/`user`[/`subdomain`]
128+
* /`serverSpace_version_USER_engineType`/`user`[/`subdomain`]
129129
* For `GROUP` share level:
130-
* /`serverSpace_GROUP_engineType`/`primary group name`[/`subdomain`]
130+
* /`serverSpace_version_GROUP_engineType`/`primary group name`[/`subdomain`]
131131
* For `SERVER` share level:
132-
* /`serverSpace_SERVER_engineType`/`kyuubi server user`[/`subdomain`]
132+
* /`serverSpace_version_SERVER_engineType`/`kyuubi server user`[/`subdomain`]
133133
*/
134134
@VisibleForTesting
135135
private[kyuubi] lazy val engineSpace: String = {

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@
125125
<jakarta.servlet-api.version>4.0.4</jakarta.servlet-api.version>
126126
<jakarta.xml-bind.version>2.3.2</jakarta.xml-bind.version>
127127
<jakarta.activation.version>1.2.1</jakarta.activation.version>
128-
<jersey.version>2.34</jersey.version>
128+
<jersey.version>2.35</jersey.version>
129129
<jetty.version>9.4.41.v20210516</jetty.version>
130130
<jline.version>0.9.94</jline.version>
131131
<kubernetes-client.version>5.12.1</kubernetes-client.version>

0 commit comments

Comments
 (0)