Skip to content

Commit c2b121d

Browse files
committed
Revert ConfigurationFactory renaming
1 parent 35c0f02 commit c2b121d

File tree

25 files changed

+303
-262
lines changed

25 files changed

+303
-262
lines changed

log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
import java.io.IOException;
2020
import java.io.InputStream;
2121
import org.apache.logging.log4j.core.LoggerContext;
22-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2322
import org.apache.logging.log4j.core.config.Configuration;
2423
import org.apache.logging.log4j.core.config.ConfigurationException;
24+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2525
import org.apache.logging.log4j.core.config.ConfigurationSource;
2626
import org.apache.logging.log4j.core.config.builder.api.ConfigurationBuilder;
2727
import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
@@ -35,7 +35,7 @@
3535
//
3636
// Best Value?
3737
// @Order(50)
38-
public class Log4j1ConfigurationFactory extends AbstractConfigurationFactory {
38+
public class Log4j1ConfigurationFactory extends ConfigurationFactory {
3939

4040
private static final String[] SUFFIXES = {".properties"};
4141

log4j-1.2-api/src/main/java/org/apache/log4j/config/PropertiesConfigurationFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
package org.apache.log4j.config;
1818

1919
import org.apache.logging.log4j.core.LoggerContext;
20-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2120
import org.apache.logging.log4j.core.config.Configuration;
21+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2222
import org.apache.logging.log4j.core.config.ConfigurationSource;
2323
import org.apache.logging.log4j.core.config.Order;
2424
import org.apache.logging.log4j.plugins.Namespace;
@@ -28,10 +28,10 @@
2828
/**
2929
* Configures Log4j from a log4j 1 format properties file.
3030
*/
31-
@Namespace(AbstractConfigurationFactory.NAMESPACE)
31+
@Namespace(ConfigurationFactory.NAMESPACE)
3232
@Plugin("Log4j1PropertiesConfigurationFactory")
3333
@Order(2)
34-
public class PropertiesConfigurationFactory extends AbstractConfigurationFactory {
34+
public class PropertiesConfigurationFactory extends ConfigurationFactory {
3535

3636
static final String FILE_EXTENSION = ".properties";
3737

@@ -48,7 +48,7 @@ public class PropertiesConfigurationFactory extends AbstractConfigurationFactory
4848
@Override
4949
public String[] getSupportedTypes() {
5050
if (!PropertiesUtil.getProperties()
51-
.getBooleanProperty(AbstractConfigurationFactory.LOG4J1_EXPERIMENTAL, Boolean.FALSE)) {
51+
.getBooleanProperty(ConfigurationFactory.LOG4J1_EXPERIMENTAL, Boolean.FALSE)) {
5252
return null;
5353
}
5454
return new String[] {FILE_EXTENSION};

log4j-1.2-api/src/main/java/org/apache/log4j/xml/XmlConfigurationFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import org.apache.log4j.config.Log4j1Configuration;
2020
import org.apache.logging.log4j.core.LoggerContext;
21-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2221
import org.apache.logging.log4j.core.config.Configuration;
22+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2323
import org.apache.logging.log4j.core.config.ConfigurationSource;
2424
import org.apache.logging.log4j.core.config.Order;
2525
import org.apache.logging.log4j.plugins.Namespace;
@@ -29,10 +29,10 @@
2929
/**
3030
* Constructs a Configuration usable in Log4j 2 from a Log4j 1 configuration file.
3131
*/
32-
@Namespace(AbstractConfigurationFactory.NAMESPACE)
32+
@Namespace(ConfigurationFactory.NAMESPACE)
3333
@Plugin("Log4j1XmlConfigurationFactory")
3434
@Order(2)
35-
public class XmlConfigurationFactory extends AbstractConfigurationFactory {
35+
public class XmlConfigurationFactory extends ConfigurationFactory {
3636

3737
public static final String FILE_EXTENSION = ".xml";
3838

@@ -49,7 +49,7 @@ public class XmlConfigurationFactory extends AbstractConfigurationFactory {
4949
@Override
5050
public String[] getSupportedTypes() {
5151
if (!PropertiesUtil.getProperties()
52-
.getBooleanProperty(AbstractConfigurationFactory.LOG4J1_EXPERIMENTAL, Boolean.FALSE)) {
52+
.getBooleanProperty(ConfigurationFactory.LOG4J1_EXPERIMENTAL, Boolean.FALSE)) {
5353
return null;
5454
}
5555
return new String[] {FILE_EXTENSION};

log4j-1.2-api/src/test/java/org/apache/log4j/BasicConfigurationFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020
import org.apache.logging.log4j.Level;
2121
import org.apache.logging.log4j.core.LoggerContext;
2222
import org.apache.logging.log4j.core.config.AbstractConfiguration;
23-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2423
import org.apache.logging.log4j.core.config.Configuration;
24+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2525
import org.apache.logging.log4j.core.config.ConfigurationSource;
2626
import org.apache.logging.log4j.core.config.LoggerConfig;
2727

2828
/**
2929
*
3030
*/
31-
public class BasicConfigurationFactory extends AbstractConfigurationFactory {
31+
public class BasicConfigurationFactory extends ConfigurationFactory {
3232

3333
@Override
3434
public String[] getSupportedTypes() {

log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationFactoryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import java.io.File;
2222
import org.apache.log4j.LogManager;
2323
import org.apache.log4j.Logger;
24-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
24+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2525
import org.junit.BeforeClass;
2626
import org.junit.Test;
2727

@@ -33,7 +33,7 @@ public class PropertiesConfigurationFactoryTest {
3333
@BeforeClass
3434
public static void beforeClass() {
3535
System.setProperty(
36-
AbstractConfigurationFactory.LOG4J1_CONFIGURATION_FILE_PROPERTY.getSystemKey(),
36+
ConfigurationFactory.LOG4J1_CONFIGURATION_FILE_PROPERTY.getSystemKey(),
3737
"target/test-classes/log4j1-file-1.properties");
3838
}
3939

log4j-1.2-api/src/test/java/org/apache/log4j/config/XmlConfigurationFactoryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import java.io.File;
2222
import org.apache.log4j.LogManager;
2323
import org.apache.log4j.Logger;
24-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
24+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2525
import org.junit.BeforeClass;
2626
import org.junit.Test;
2727

@@ -33,7 +33,7 @@ public class XmlConfigurationFactoryTest {
3333
@BeforeClass
3434
public static void beforeClass() {
3535
System.setProperty(
36-
AbstractConfigurationFactory.LOG4J1_CONFIGURATION_FILE_PROPERTY.getSystemKey(),
36+
ConfigurationFactory.LOG4J1_CONFIGURATION_FILE_PROPERTY.getSystemKey(),
3737
"target/test-classes/log4j1-file.xml");
3838
}
3939

log4j-config-properties/src/main/java/org/apache/logging/log4j/config/properties/JavaPropsConfigurationFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
package org.apache.logging.log4j.config.properties;
1818

1919
import org.apache.logging.log4j.core.LoggerContext;
20-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2120
import org.apache.logging.log4j.core.config.Configuration;
21+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2222
import org.apache.logging.log4j.core.config.ConfigurationSource;
2323
import org.apache.logging.log4j.core.config.Order;
2424
import org.apache.logging.log4j.plugins.Namespace;
2525
import org.apache.logging.log4j.plugins.Plugin;
2626

27-
@Namespace(AbstractConfigurationFactory.NAMESPACE)
27+
@Namespace(ConfigurationFactory.NAMESPACE)
2828
@Plugin
2929
@Order(8)
30-
public class JavaPropsConfigurationFactory extends AbstractConfigurationFactory {
30+
public class JavaPropsConfigurationFactory extends ConfigurationFactory {
3131

3232
/**
3333
* The file extensions supported by this factory.

log4j-config-yaml/src/main/java/org/apache/logging/log4j/config/yaml/YamlConfigurationFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
package org.apache.logging.log4j.config.yaml;
1818

1919
import org.apache.logging.log4j.core.LoggerContext;
20-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2120
import org.apache.logging.log4j.core.config.Configuration;
21+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2222
import org.apache.logging.log4j.core.config.ConfigurationSource;
2323
import org.apache.logging.log4j.core.config.Order;
2424
import org.apache.logging.log4j.plugins.Namespace;
2525
import org.apache.logging.log4j.plugins.Plugin;
2626

27-
@Namespace(AbstractConfigurationFactory.NAMESPACE)
27+
@Namespace(ConfigurationFactory.NAMESPACE)
2828
@Plugin("YamlConfigurationFactory")
2929
@Order(7)
30-
public class YamlConfigurationFactory extends AbstractConfigurationFactory {
30+
public class YamlConfigurationFactory extends ConfigurationFactory {
3131

3232
/**
3333
* The file extensions supported by this factory.

log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/BasicConfigurationFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import org.apache.logging.log4j.Level;
2121
import org.apache.logging.log4j.core.LoggerContext;
2222
import org.apache.logging.log4j.core.config.AbstractConfiguration;
23-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2423
import org.apache.logging.log4j.core.config.Configuration;
24+
import org.apache.logging.log4j.core.config.ConfigurationFactory;
2525
import org.apache.logging.log4j.core.config.ConfigurationSource;
2626
import org.apache.logging.log4j.core.config.LoggerConfig;
2727
import org.apache.logging.log4j.plugins.di.ConfigurableInstanceFactory;
@@ -31,7 +31,7 @@
3131
/**
3232
*
3333
*/
34-
public class BasicConfigurationFactory extends AbstractConfigurationFactory {
34+
public class BasicConfigurationFactory extends ConfigurationFactory {
3535

3636
@Override
3737
public Configuration getConfiguration(

log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/junit/ConfigurationFactoryType.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@
2121
import java.lang.annotation.Retention;
2222
import java.lang.annotation.RetentionPolicy;
2323
import java.lang.annotation.Target;
24-
import org.apache.logging.log4j.core.config.AbstractConfigurationFactory;
2524
import org.apache.logging.log4j.core.config.ConfigurationFactory;
25+
import org.apache.logging.log4j.core.config.URIConfigurationFactory;
2626

2727
/**
28-
* Specifies a particular {@link AbstractConfigurationFactory} class to use for a test class or method instead of the default.
28+
* Specifies a particular {@link ConfigurationFactory} class to use for a test class or method instead of the default.
2929
*/
3030
@Retention(RetentionPolicy.RUNTIME)
3131
@Target({ElementType.TYPE, ElementType.METHOD})
3232
@Inherited
3333
@Log4jTest
3434
public @interface ConfigurationFactoryType {
35-
Class<? extends ConfigurationFactory> value();
35+
Class<? extends URIConfigurationFactory> value();
3636
}

0 commit comments

Comments
 (0)