Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review formatting of boolean strings (in ToString() methods and similar) #921

Open
paulirwin opened this issue Feb 25, 2024 · 0 comments
Open
Labels
is:enhancement New feature or request is:task A chore to be done pri:normal up-for-grabs This issue is open to be worked on by anyone

Comments

@paulirwin
Copy link
Contributor

paulirwin commented Feb 25, 2024

Context: See PR #914

Any ideas what the string returned here is supposed to represent?

Java: spanNear([f:lucene, f:net, f:solr], 0, true)
.NET: SpanNear([f:lucene, f:net, f:solr], 0, True)

This looks like something that may be copied and pasted somewhere to me, but it may just be a textual description. If the former, we should probably at least strive to match the case of the boolean. I am guessing the name is the correct casing for .NET, though.

Of course, we are probably using upper case for all booleans converted to string in .NET, because that is what .NET does by default. So, whatever the fix, it should be applied consistently in all queries.

Originally posted by @NightOwl888 in #914 (comment)

@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone is:enhancement New feature or request pri:normal is:task A chore to be done labels Mar 10, 2024
@NightOwl888 NightOwl888 changed the title Review formatting of boolean strings Review formatting of boolean strings (in ToString() methods and similar) Mar 10, 2024
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement New feature or request is:task A chore to be done pri:normal up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants