JUnit Jupiter best practices (#185)

Co-authored-by: Moderne <team@moderne.io>

Author: slachiewicz

src/test/java/org/apache/maven/plugins/ejb/IncludesExcludesTest.java

@@ -21,9 +21,10 @@
 import java.util.Arrays;
 import java.util.Collections;
 
-import org.junit.Assert;
 import org.junit.Test;
 
+import static org.junit.Assert.assertArrayEquals;
+
 public class IncludesExcludesTest {
 
     @Test
@@ -32,8 +33,8 @@ public void emptyListsShouldResultInZeroSizeResults() {
                 Collections.<String>emptyList(), Collections.<String>emptyList(),
                 Collections.<String>emptyList(), Collections.<String>emptyList());
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
+        assertArrayEquals(new String[0], ie.resultingIncludes());
+        assertArrayEquals(new String[0], ie.resultingExcludes());
     }
 
     @Test
@@ -44,8 +45,8 @@ public void nullForIncludesShouldResultInZeroSizeResults() {
                 Collections.<String>emptyList(),
                 Collections.<String>emptyList());
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
+        assertArrayEquals(new String[0], ie.resultingIncludes());
+        assertArrayEquals(new String[0], ie.resultingExcludes());
     }
 
     @Test
@@ -56,26 +57,26 @@ public void nullForExcludesShouldResultInZeroSizeResults() {
                 Collections.<String>emptyList(),
                 Collections.<String>emptyList());
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
+        assertArrayEquals(new String[0], ie.resultingIncludes());
+        assertArrayEquals(new String[0], ie.resultingExcludes());
     }
 
     @Test
     public void nonNullForDefaultExcludesShouldResultInExcludesWithDefaultExcludes() {
         IncludesExcludes ie =
                 new IncludesExcludes(null, null, Collections.<String>emptyList(), Arrays.asList("**/package.html"));
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[] {"**/package.html"});
+        assertArrayEquals(new String[0], ie.resultingIncludes());
+        assertArrayEquals(new String[] {"**/package.html"}, ie.resultingExcludes());
     }
 
     @Test
     public void nonNullForDefaultIncludesShouldResultInIncludesWithDefaultIncludes() {
         IncludesExcludes ie =
                 new IncludesExcludes(null, null, Arrays.asList("**/package.html"), Collections.<String>emptyList());
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[] {"**/package.html"});
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
+        assertArrayEquals(new String[] {"**/package.html"}, ie.resultingIncludes());
+        assertArrayEquals(new String[0], ie.resultingExcludes());
     }
 
     @Test
@@ -84,7 +85,7 @@ public void nonNullIncludesShouldResultInTheSameIncludes() {
                 Arrays.asList("**/package.html"), null,
                 Arrays.asList("**/site.html"), null);
 
-        Assert.assertArrayEquals(ie.resultingIncludes(), new String[] {"**/package.html"});
+        assertArrayEquals(new String[] {"**/package.html"}, ie.resultingIncludes());
     }
 
     @Test
@@ -93,6 +94,6 @@ public void nonNullExcludesShouldResultInTheSameExcludes() {
                 null, Arrays.asList("**/package.html"),
                 null, Arrays.asList("**/site.html"));
 
-        Assert.assertArrayEquals(ie.resultingExcludes(), new String[] {"**/package.html"});
+        assertArrayEquals(new String[] {"**/package.html"}, ie.resultingExcludes());
     }
 }