Skip to content

Commit 81f2998

Browse files
committed
MPLUGINTESTING-44 maven 3.2.4 compatibility
Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
1 parent 08cbd18 commit 81f2998

File tree

4 files changed

+4
-20
lines changed

4 files changed

+4
-20
lines changed

maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@
4242
import org.apache.maven.execution.MavenExecutionRequest;
4343
import org.apache.maven.execution.MavenExecutionResult;
4444
import org.apache.maven.execution.MavenSession;
45-
import org.apache.maven.execution.scope.MojoExecutionScoped;
46-
import org.apache.maven.execution.scope.internal.MojoExecutionScope;
4745
import org.apache.maven.lifecycle.internal.MojoDescriptorCreator;
4846
import org.apache.maven.model.Plugin;
4947
import org.apache.maven.monitor.logging.DefaultLog;
@@ -80,7 +78,6 @@
8078
import org.codehaus.plexus.util.xml.Xpp3Dom;
8179
import org.codehaus.plexus.util.xml.Xpp3DomBuilder;
8280

83-
import com.google.inject.AbstractModule;
8481
import com.google.inject.Module;
8582

8683
/**
@@ -226,19 +223,6 @@ protected void setupContainer()
226223
try
227224
{
228225
List<Module> modules = new ArrayList<Module>();
229-
modules.add( new AbstractModule()
230-
{
231-
@Override
232-
protected void configure()
233-
{
234-
// execution scope bindings (core binds these in plugin realm injector only)
235-
MojoExecutionScope executionScope = new MojoExecutionScope();
236-
bindScope( MojoExecutionScoped.class, executionScope );
237-
bind( MojoExecutionScope.class ).toInstance( executionScope );
238-
bind( MavenProject.class ).toProvider( MojoExecutionScope.<MavenProject> seededKeyProvider() ).in( executionScope );
239-
bind( MojoExecution.class ).toProvider( MojoExecutionScope.<MojoExecution> seededKeyProvider() ).in( executionScope );
240-
}
241-
} );
242226
addGuiceModules( modules );
243227
container = new DefaultPlexusContainer( cc, modules.toArray( new Module[modules.size()] ) );
244228
}

maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/MojoRule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import java.io.InputStream;
2424
import java.util.Map;
2525

26-
import org.apache.maven.SessionScope;
2726
import org.apache.maven.execution.DefaultMavenExecutionRequest;
2827
import org.apache.maven.execution.MavenExecutionRequest;
2928
import org.apache.maven.execution.MavenSession;
@@ -35,6 +34,7 @@
3534
import org.apache.maven.project.MavenProject;
3635
import org.apache.maven.project.ProjectBuilder;
3736
import org.apache.maven.project.ProjectBuildingRequest;
37+
import org.apache.maven.session.scope.internal.SessionScope;
3838
import org.codehaus.plexus.ContainerConfiguration;
3939
import org.codehaus.plexus.PlexusContainer;
4040
import org.codehaus.plexus.component.configurator.ComponentConfigurationException;

maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/ParametersMojoTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,11 @@
2525
import org.apache.maven.execution.MavenExecutionRequest;
2626
import org.apache.maven.execution.MavenSession;
2727
import org.apache.maven.plugin.MojoExecution;
28-
import org.apache.maven.plugin.testing.AbstractMojoTestCase;
29-
import org.apache.maven.plugin.testing.ParametersMojo;
3028
import org.apache.maven.project.MavenProject;
3129
import org.apache.maven.project.ProjectBuilder;
3230
import org.apache.maven.project.ProjectBuildingException;
3331
import org.apache.maven.project.ProjectBuildingRequest;
32+
import org.eclipse.aether.DefaultRepositorySystemSession;
3433

3534
public class ParametersMojoTest
3635
extends AbstractMojoTestCase
@@ -100,6 +99,7 @@ protected MavenProject readMavenProject( File basedir )
10099
MavenExecutionRequest request = new DefaultMavenExecutionRequest();
101100
request.setBaseDirectory( basedir );
102101
ProjectBuildingRequest configuration = request.getProjectBuildingRequest();
102+
configuration.setRepositorySession( new DefaultRepositorySystemSession() );
103103
MavenProject project = lookup( ProjectBuilder.class ).build( pom, configuration ).getProject();
104104
assertNotNull( project );
105105
return project;

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ under the License.
145145
</distributionManagement>
146146

147147
<properties>
148-
<mavenVersion>3.2.1</mavenVersion>
148+
<mavenVersion>3.2.4-SNAPSHOT</mavenVersion>
149149
<plexusVersion>1.5.5</plexusVersion>
150150
<maven.site.path>plugin-testing-archives/LATEST</maven.site.path>
151151
<!-- Not sure if this is intentional but MojoRule has an @Override annotation from the interface which is

0 commit comments

Comments
 (0)