Fix it wrong version of junit

Signed-off-by: Olivier Lamy <olamy@apache.org>

Author: olamy

surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgVersionsIT.java

@@ -43,12 +43,12 @@ public class CheckTestNgVersionsIT extends SurefireJUnitIntegrationTestCase {
     // TestNG 7.6 and above needs JDK11
     @Test
     public void test751() {
-        runTestNgTestWithRunOrder("7.5.1");
+        runTestNgTest("7.5.1");
     }
 
     @Test
     public void test6143() {
-        runTestNgTestWithRunOrder("6.14.3");
+        runTestNgTest("6.14.3");
     }
 
     @Test
@@ -71,43 +71,28 @@ public void test6821() {
                 .verifyTextInLog("TestNG support requires version 6.14.3 or above");
     }
 
-    private void runTestNgTestWithRunOrder(String version) {
-        runTestNgTest(version, null, true);
-    }
-
     private void runTestNgTest(String version) {
-        runTestNgTest(version, null, false);
-    }
-
-    private void runTestNgTest(String version, String classifier) {
-        runTestNgTest(version, classifier, false);
-    }
-
-    private void runTestNgTest(String version, String classifier, boolean validateRunOrder) {
         final SurefireLauncher launcher = unpack("testng-simple").sysProp("testNgVersion", version);
 
         final OutputValidator outputValidator = launcher.executeTest();
 
         outputValidator.assertTestSuiteResults(3, 0, 0, 0);
 
-        if (validateRunOrder) {
-            // assert correct run order of tests
-            List<ReportTestSuite> report = HelperAssertions.extractReports(outputValidator.getBaseDir());
+        // assert correct run order of tests
+        List<ReportTestSuite> report = HelperAssertions.extractReports(outputValidator.getBaseDir());
+
+        assertEquals(3, report.size());
 
-            assertEquals(3, report.size());
+        // Validate order
 
-            assertTrue(
-                    "TestNGSuiteTestC was not executed first",
-                    getTestClass(report, 0).endsWith("TestNGSuiteTestC"));
+        assertTrue(
+                "TestNGSuiteTestC was not executed first",
+                getTestClass(report, 0).endsWith("TestNGSuiteTestC"));
 
-            assertTrue(
-                    "TestNGSuiteTestB was executed second",
-                    getTestClass(report, 1).endsWith("TestNGSuiteTestB"));
+        assertTrue(
+                "TestNGSuiteTestB was executed second", getTestClass(report, 1).endsWith("TestNGSuiteTestB"));
 
-            assertTrue(
-                    "TestNGSuiteTestA was executed last",
-                    getTestClass(report, 2).endsWith("TestNGSuiteTestA"));
-        }
+        assertTrue("TestNGSuiteTestA was executed last", getTestClass(report, 2).endsWith("TestNGSuiteTestA"));
     }
 
     private String getTestClass(List<ReportTestSuite> report, int i) {

surefire-its/src/test/resources/testng-simple/pom.xml

@@ -31,7 +31,6 @@
   <properties>
     <surefire.testng.verbose>0</surefire.testng.verbose>
     <argLine/>
-    <jacoco.agent/>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
   </properties>
@@ -57,7 +56,7 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <version>${surefire.version}</version>
         <configuration>
-          <argLine>${argLine} "${jacoco.agent}"</argLine>
+          <argLine>${argLine}</argLine>
           <runOrder>reversealphabetical</runOrder>
           <properties>
             <property>

surefire-its/src/test/resources/working-directory-missing/pom.xml

@@ -33,7 +33,7 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
-      <version>3.8.2</version>
+      <version>4.13.2</version>
       <scope>test</scope>
     </dependency>
   </dependencies>