Skip to content

Add additional locations for auto-discovery to scan #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Okeanos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add additional locations for auto-discovery to scan #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,11 @@ private Set<Path> doFindJdks() {
installedDirs.add(userHome.resolve(".jbang").resolve("cache").resolve("jdks"));
installedDirs.add(userHome.resolve(".asdf").resolve("installs"));
installedDirs.add(userHome.resolve(".jabba").resolve("jdk"));
installedDirs.add(userHome.resolve(".local")
.resolve("share")
.resolve("mise")
.resolve("installs")
.resolve("java"));

// OS related directories
String osname = System.getProperty("os.name").toLowerCase(Locale.ROOT);
Expand All @@ -436,8 +441,10 @@ private Set<Path> doFindJdks() {
if (macos) {
installedDirs.add(Paths.get("/Library/Java/JavaVirtualMachines"));
installedDirs.add(userHome.resolve("Library/Java/JavaVirtualMachines"));
installedDirs.add(userHome.resolve("hostedtoolcache"));
} else if (win) {
installedDirs.add(Paths.get("C:\\Program Files\\Java\\"));
installedDirs.add(Paths.get("C:\\hostedtoolcache\\windows\\"));
Path scoop = userHome.resolve("scoop").resolve("apps");
if (Files.isDirectory(scoop)) {
try (Stream<Path> stream = Files.list(scoop)) {
Expand All @@ -449,8 +456,11 @@ private Set<Path> doFindJdks() {
} else {
installedDirs.add(Paths.get("/usr/jdk"));
installedDirs.add(Paths.get("/usr/java"));
installedDirs.add(Paths.get("/usr/local/java"));
Copy link
Contributor

@gnodet gnodet Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which tool uses this directory ?

Copy link
Contributor Author

@Okeanos Okeanos Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on the proposed alignment with the Gradle toolchain detection I mentioned in #129 – the original proposal for Gradle is documented in gradle/gradle#23620 and boils down to "people put it there during manual installations as common default".

I have no strong opinion on this and I am willing to exclude this particular search folder as it is a "customary" but ultimately a user-defined location.

installedDirs.add(Paths.get("/opt/java"));
installedDirs.add(Paths.get("/opt/hostedtoolcache"));
installedDirs.add(Paths.get("/usr/lib/jvm"));
installedDirs.add(Paths.get("/usr/lib64/jvm"));
}

for (Path dest : installedDirs) {
Expand Down
Loading