Merge pull request #467 from zakharovsergey1000/master

tomaswolf · web-flow · commit a6dad81f2627 · 2024-04-02T20:08:48.000+02:00
Synchronize not thread safe java.security.KeyPairGenerator.generateKe…
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/kex/MontgomeryCurve.java b/sshd-core/src/main/java/org/apache/sshd/common/kex/MontgomeryCurve.java
@@ -153,7 +153,9 @@ public Digest createDigest() {
     }
 
     public KeyPair generateKeyPair() {
-        return keyPairGenerator.generateKeyPair();
+        synchronized (this) {
+            return keyPairGenerator.generateKeyPair();
+        }
     }
 
     public byte[] encode(PublicKey key) throws InvalidKeyException {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,9 @@ public Digest createDigest() {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`public KeyPair generateKeyPair() {`
`156`		`- return keyPairGenerator.generateKeyPair();`
	`156`	`+ synchronized (this) {`
	`157`	`+ return keyPairGenerator.generateKeyPair();`
	`158`	`+ }`
`157`	`159`	`}`
`158`	`160`
`159`	`161`	`public byte[] encode(PublicKey key) throws InvalidKeyException {`