Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Missing return value documentation for nd.random.* and sym.random.* #13227

Closed
eric-haibin-lin opened this issue Nov 12, 2018 · 7 comments
Closed

Comments

@eric-haibin-lin
Copy link
Member

eric-haibin-lin commented Nov 12, 2018

The operators in https://mxnet.incubator.apache.org/api/python/ndarray/random.html#random-distribution-generator don't mention the return value types and the number of return values.

  • multinomial
  • generalized_negative_binomial
  • negative_binomial
  • gamma
  • exponential
  • randn
@zachgk
Copy link
Contributor

zachgk commented Nov 15, 2018

@mxnet-label-bot add [Python]

Thank you for submitting the issue! I'm labeling it so the MXNet community members can help resolve it.

@aaronmarkham
Copy link
Contributor

@mxnet-label-bot add [good first issue]
The operators don't have documentation on their return type. Someone could play with them and to get familiar with them and then add the return type info using the ops that have it specified as a template.

@zboldyga
Copy link
Contributor

I'll check this out tonight and/or tomorrow!

@thomelane
Copy link
Contributor

@zboldyga did you get a chance to check this out? let me know if not, and i'll take a look. thanks!

@zboldyga
Copy link
Contributor

zboldyga commented Jan 10, 2019

@thomelane whoops, I lost track of this one after the holidays. It's mostly complete but I need to revise and submit a pull request this weekend. Thanks for the reminder!

@safrooze
Copy link
Contributor

@zboldyga gentle check to see if you've submitted a PR?

@zboldyga
Copy link
Contributor

Just filed it: #13994 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants