Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Julia tests always test master branch of MXNet instead of the PR branch #18061

Closed
leezu opened this issue Apr 15, 2020 · 0 comments · Fixed by #18056
Closed

Julia tests always test master branch of MXNet instead of the PR branch #18061

leezu opened this issue Apr 15, 2020 · 0 comments · Fixed by #18056
Labels

Comments

@leezu
Copy link
Contributor

leezu commented Apr 15, 2020

Description

https://github.com/apache/incubator-mxnet/blob/e796ae9684df5eb94202d7ab012772b3d9442a4f/ci/docker/runtime_functions.sh#L1238-L1259

https://github.com/apache/incubator-mxnet/blob/8e50fd9d862a2917e0727b8cd17f1e5cf0eba081/julia/deps/build.jl#L25-L43

falls back to building MXNet master branch if it can't find the prebuild libmxnet.so. As the location of libmxnet.so changed when switching CI to cmake in #17645, our Julia testing stage has ever since rebuilt MXNet master branch during the testing stage and only tested that.

Will fix as part of #18056

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant