Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/redis: Implement Write::append with native support #1449

Closed
3 tasks
Xuanwo opened this issue Mar 1, 2023 · 3 comments · Fixed by #1651
Closed
3 tasks

services/redis: Implement Write::append with native support #1449

Xuanwo opened this issue Mar 1, 2023 · 3 comments · Fixed by #1651
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 1, 2023

All kv servcices are handling Write::append in memory:

https://github.com/datafuselabs/opendal/blob/88e3b0b3cd9bde47471b10c81bbec76ca286011a/src/raw/adapters/kv/backend.rs#L284-L288

But services like redis have native append support, for example: https://redis.io/commands/append/. We can adopt this feature to have a better append implement.

To support this, we need:

  • Add append/blocking_append in kv adapter
  • Use append if the kv backend has append support
  • Implement append for redis service
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 1, 2023
@uran0sH
Copy link
Contributor

uran0sH commented Mar 7, 2023

I would like to work on it. Could you provide more details?

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 8, 2023

Hi, @uran0sH, thank you for your interest! I have now updated the issue's description. Please take a look.

@uran0sH
Copy link
Contributor

uran0sH commented Mar 8, 2023

Ok, thank you. I will try to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants