Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/python: Switch to python/rust mixed layout #1728

Closed
Xuanwo opened this issue Mar 22, 2023 · 3 comments · Fixed by #1729
Closed

bindings/python: Switch to python/rust mixed layout #1728

Xuanwo opened this issue Mar 22, 2023 · 3 comments · Fixed by #1729

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 22, 2023

          For pure Rust project layout, the `.so` file name has to be `opendal` because that's how Python `import` works. We can switch to mixed Python/Rust layout to change it to whatever we want. (And usually we use `_opendal` and re-export public APIs in Python `opendal` module).

Originally posted by @messense in #1205 (comment)

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 22, 2023

By this switching, we can:

  • allow rust opendal-python export libopendal_python.so
  • Export public API directly at python side

@messense
Copy link
Member

I'll do it later.

@tisonkun
Copy link
Member

IMO C bindings can reserve the "libopendal.so" name. Other language binding cdylib is used by the specific language only so that we don't care about the lib name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants