Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some log level from INFO to DEBUG #177

Closed
BohuTANG opened this issue Mar 24, 2022 · 4 comments · Fixed by #181
Closed

Change some log level from INFO to DEBUG #177

BohuTANG opened this issue Mar 24, 2022 · 4 comments · Fixed by #181

Comments

@BohuTANG
Copy link

Summary

When the writing, there are many INFO logs like:

^[[2m2022-03-24T01:17:32.380414Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/2aae204afad246fb831a46e4c9295af3.parquet write finished: size 23568191
^[[2m2022-03-24T01:17:40.623754Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/b2b68e74bb7b45fb93cc94b829fd71d1.parquet write start: size 23359904
^[[2m2022-03-24T01:17:41.120315Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/b2b68e74bb7b45fb93cc94b829fd71d1.parquet write finished: size 23359904
^[[2m2022-03-24T01:17:49.340867Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/6c53ebe5329b4318ad62ba3d849a5c6b.parquet write start: size 23647628
^[[2m2022-03-24T01:17:49.840158Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/6c53ebe5329b4318ad62ba3d849a5c6b.parquet write finished: size 23647628
^[[2m2022-03-24T01:17:57.963409Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/6af1e2ce75fe46bab58059305fbd6f7e.parquet write start: size 24015355
^[[2m2022-03-24T01:17:58.461119Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/6af1e2ce75fe46bab58059305fbd6f7e.parquet write finished: size 24015355
^[[2m2022-03-24T01:18:06.363321Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/a6def66e15bc484bb5a57a0c027b87c1.parquet write start: size 25166810
^[[2m2022-03-24T01:18:06.940801Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/a6def66e15bc484bb5a57a0c027b87c1.parquet write finished: size 25166810
^[[2m2022-03-24T01:18:14.923211Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/c1f55201c7b243cfa14b0c310538e723.parquet write start: size 24117754
^[[2m2022-03-24T01:18:15.422110Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/c1f55201c7b243cfa14b0c310538e723.parquet write finished: size 24117754
^[[2m2022-03-24T01:18:23.103621Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/672af1c75b6a41eb9d6f49805d9a8bea.parquet write start: size 23143636
^[[2m2022-03-24T01:18:23.621079Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/672af1c75b6a41eb9d6f49805d9a8bea.parquet write finished: size 23143636
^[[2m2022-03-24T01:18:31.531304Z^[[0m ^[[32m INFO^[[0m ^[[2mopendal::services::s3::backend^[[0m^[[2m:^[[0m object 1/1/_b/a2748a91c967468cb338ff1e36713f17.parquet write start: size 23367337

I think this is only for debug, can we change them to DEBUG level?
By the way, prefer to INFO the request_id, this is useful for object storage developer to tracing.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2022

Makes sense, we will level down the request log.

@wubx
Copy link

wubx commented Mar 24, 2022

Please add request return code

@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2022

Please add request return code

The current behavior is:

  • If the request is OK (returns the expected code), we will not log anything about this request.
  • If the request is wrong (returns 403/404/500), we will log the whole response, including status code, headers, body content.

Is this behavior fulfills your need?

Also, ask @BohuTANG, do you need the status code and request-id even when the request is successful?

@Xuanwo Xuanwo linked a pull request Mar 25, 2022 that will close this issue
@BohuTANG
Copy link
Author

Sorry for the later, the log is OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants