How about ignore formatting opendal.h?

[wcy-fdu]

may format once bindings/c/include/opendal.h to ensure that future PRs will not change this file...

[Xuanwo]

cargo fmt won't change opendal.h as far as I know. Maybe related to different clang-format version?

[Xuanwo]

Maybe we should leave opendal.h AS-IS. And don't format it by any tools...

[suyanhanx]

Maybe we should leave opendal.h AS-IS. And don't format it by any tools...

An automatically generated file, that's fine to leave it AS-IS. 😅

[Xuanwo]

cc @Ji-Xinyou, what do you think? Is it a good idea to ignore formating of opendal.h?

[xyjixyjixyji]

cc @Ji-Xinyou, what do you think? Is it a good idea to ignore formating of opendal.h?

I tried in my machine that cargo fmt will not format the opendal.h. I not quite getting the point why we are trying to ignore the formatting of opendal.h.

[Xuanwo]

I tried in my machine that cargo fmt will not format the opendal.h.

It's not related to cargo fmt, the root cause is different versions (or kinds) of clang-format as we found in #2053

I not quite getting the point why we are trying to ignore the formatting of opendal.h.

Currently, we are running clang-format in build.rs to format opendal.h everytime we invoke the build of opendal-c. There are following drawbacks:

• Developers who don't know about opendal-c also needs to install clang-format.
• There are different kinds and versions of clang-format (6, 7, 8, 9, 10, 15) and could led to different results.
• opendal.h is a generated file and not maintain by hands.

[xyjixyjixyji]

I tried in my machine that cargo fmt will not format the opendal.h.

It's not related to cargo fmt, the root cause is different versions (or kinds) of clang-format as we found in #2053

I not quite getting the point why we are trying to ignore the formatting of opendal.h.

Currently, we are running clang-format in build.rs to format opendal.h everytime we invoke the build of opendal-c. There are following drawbacks:

• Developers who don't know about opendal-c also needs to install clang-format.
• There are different kinds and versions of clang-format (6, 7, 8, 9, 10, 15) and could led to different results.
• opendal.h is a generated file and not maintain by hands.

I see your point. The root cause is that different version of clang-format causes different formatting results.
Considering this, I think we could ignore the formatting since it is in the end an auto-generated file.

• If the formatting is needed by the user, they copy it to their include directory and format by themselves.

[Xuanwo]

Considering this, I think we could ignore the formatting since it is in the end an auto-generated file.

Great! Would you like to make changes to the Makefile and build.rs?

[xyjixyjixyji]

Considering this, I think we could ignore the formatting since it is in the end an auto-generated file.

Great! Would you like to make changes to the Makefile and build.rs?

Of course, working on it.