Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Mark job as skipped if secrets not loaded #2127

Closed
Xuanwo opened this issue Apr 26, 2023 · 0 comments · Fixed by #2128
Closed

ci: Mark job as skipped if secrets not loaded #2127

Xuanwo opened this issue Apr 26, 2023 · 0 comments · Fixed by #2128

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 26, 2023

Some of OpenDAL's behavior tests depends on it's secrets and will skip tests if secrets not loaded. This could be confusing for our contributors to see the checks always passed. We should mark job as skipped if secrets not loaded.

This could be checked by value like OPENDAL_S3_TEST: ${{ secrets.OPENDAL_S3_TEST }}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Mark job as skipped if owner is not apache apache/opendal
1 participant
@Xuanwo