Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read batch_max_operations from config instead #2228

Closed
3 tasks done
Xuanwo opened this issue May 7, 2023 · 9 comments
Closed
3 tasks done

Read batch_max_operations from config instead #2228

Xuanwo opened this issue May 7, 2023 · 9 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 7, 2023

As discussed in #2227, batch_max_operations could be different for diffent services, so we should allow users to configure it instead.

Actions

We should add new batch_max_operations config for service and use default value if not set.

Tasks

@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels May 7, 2023
@manulpatel
Copy link
Contributor

Hello @Xuanwo! I am new to OpenDAL community and would like to work on this issue.

@Xuanwo
Copy link
Member Author

Xuanwo commented May 8, 2023

Great, we can start with add support for s3 first!

@manulpatel
Copy link
Contributor

Hello @A-Stupid-Sun! You can continue to work on this issue and develop remaining 2 functionalities. Very Sorry @Xuanwo, I was occupied with other things, since last few days and not able to give time on this.

@A-Stupid-Sun
Copy link
Contributor

Hello @A-Stupid-Sun! You can continue to work on this issue and develop remaining 2 functionalities. Very Sorry @Xuanwo, I was occupied with other things, since last few days and not able to give time on this.

no problem, I just start learning rust and your contribution give me much inspiration to fix it, thanks a lot!

@manulpatel
Copy link
Contributor

Great! You can use my branch for s3 and close it soon.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 5, 2023

Very Sorry @Xuanwo, I was occupied with other things, since last few days and not able to give time on this.

That's ok, take your time and have fun! There is no sorry needed here.

@A-Stupid-Sun
Copy link
Contributor

hi @Xuanwo, I wonder if it's necessary to add a new "batch_max_operations" config for the azbolb service ?
if it's necessary , I'm willing to fix it to close this issue.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 7, 2023

Thanks a lot! Let's do this.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 8, 2023

Thanks to @A-Stupid-Sun, all issues have been resolved. Closing now!

@Xuanwo Xuanwo closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants