Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: Change s3 security_token to session_token #4874

Closed
Zyyeric opened this issue Jul 9, 2024 · 6 comments
Closed

idea: Change s3 security_token to session_token #4874

Zyyeric opened this issue Jul 9, 2024 · 6 comments
Assignees
@Zyyeric

Comments

@Zyyeric
Copy link
Contributor

Zyyeric commented Jul 9, 2024

In 2014 Amazon switched from AWS_SECURITY_TOKEN to AWS_SESSION_TOKEN. Thus, to be consistent with the naming of AWS STS, would it be more favourably to switch the naming to session_token?
@Xuanwo
Copy link
Member

Xuanwo commented Jul 9, 2024 •
edited
Loading

It makes sense to me. We can mark security_token as deprecated and add new session_token config.

Would you like to help with this?

@Zyyeric
Copy link
Contributor Author

Zyyeric commented Jul 9, 2024

Yes, I can implement this change

@Xuanwo
Copy link
Member

Xuanwo commented Jul 9, 2024

Yes, I can implement this change

Welcome! Have fun.

@Zyyeric Zyyeric mentioned this issue Jul 9, 2024
Merged
@Xuanwo
Copy link
Member

Xuanwo commented Jul 10, 2024

Thank @Zyyeric to help addressing this issue.

@Xuanwo Xuanwo closed this as completed Jul 10, 2024
@suyanhanx
Copy link
Member

Would this be a break change?

@Xuanwo
Copy link
Member

Xuanwo commented Jul 11, 2024

Would this be a break change?

Yes, it's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zyyeric Zyyeric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuanwo @suyanhanx @Zyyeric