Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: failed to run custom build command for aws-lc-sys v0.20.1 #5048

Closed
1 task
photino opened this issue Aug 25, 2024 · 6 comments
Closed
1 task

bug: failed to run custom build command for aws-lc-sys v0.20.1 #5048

photino opened this issue Aug 25, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@photino
Copy link
Contributor

photino commented Aug 25, 2024

Describe the bug

OpenDAL has a reqwest/rustls-tls as a default feature. But rustls can not compile without NASM on windows: rustls/rustls#1913

Steps to Reproduce

[dependencies.opendal]
version = "0.49.1"

Expected Behavior

It should does not depend on aws-lc-sys by default.

Additional Context

No response

Are you willing to submit a PR to fix this bug?

  • Yes, I would like to submit a PR.
@photino photino added the bug Something isn't working label Aug 25, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Aug 25, 2024

It should does not depend on aws-lc-sys by default.

Hi, reqwest enables ring by default.

https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml

rustls-tls-manual-roots = ["__rustls", "__rustls-ring"]
rustls-tls-webpki-roots = ["dep:webpki-roots", "hyper-rustls?/webpki-tokio", "__rustls", "__rustls-ring"]
rustls-tls-native-roots = ["dep:rustls-native-certs", "hyper-rustls?/native-tokio", "__rustls", "__rustls-ring"]
rustls-tls-manual-roots-no-provider = ["__rustls"]

Please check your dependency tree to see if there are other crates enabling Rustls default features.

@photino
Copy link
Contributor Author

photino commented Aug 25, 2024

I am not sure what leads to the rustls default features. But when I remove the opendal dependency in our project, all compiles successfully.

@photino
Copy link
Contributor Author

photino commented Aug 25, 2024

Perhaps it is an issue related to the services-mysql.

[dependencies.mysql_async]
default-features = false
features = ["default-rustls"]
optional = true
version = "0.34"

Related to blackbeam/mysql_async#316

@Xuanwo
Copy link
Member

Xuanwo commented Aug 25, 2024

Perhaps it is an issue related to the services-mysql.

Yes, this is an issue we've encountered before: #5000

@Xuanwo
Copy link
Member

Xuanwo commented Sep 1, 2024

Closing for not related to opendal.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2024
@aawsome
Copy link
Contributor

aawsome commented Nov 27, 2024

We are seeing the same problem for service-ftp. Seems like suppaftp does use rustls default features..

see veeso/suppaftp#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants