Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: Build opendal Operator via object_store's Options #5190

Open
1 task
Xuanwo opened this issue Oct 16, 2024 · 5 comments
Open
1 task

new feature: Build opendal Operator via object_store's Options #5190

Xuanwo opened this issue Oct 16, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 16, 2024

Feature Description

object_store_opendal enables users to utilize opendal as object_store::ObjectStore. Consequently, we can facilitate the construction of the opendal Operator through the object_store's Options, allowing users to employ the same configuration pattern consistently.

Problem and Solution

Some object_store users heavily rely on the Options input of object_store. We can use these options to directly build an opendal Operator, thereby simplifying their experience.

Additional Context

No response

Are you willing to contribute to the development of this feature?

  • Yes, I am willing to contribute to the development of this feature.
@Xuanwo Xuanwo added the enhancement New feature or request label Oct 16, 2024
@meteorgan
Copy link
Contributor

Could you clarify what the object_store options refer to? GetOptions and PutOptions ?

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 25, 2024

Hi, I'm talking about the config key like: https://docs.rs/object_store/0.11.1/object_store/aws/enum.AmazonS3ConfigKey.html

@meteorgan
Copy link
Contributor

Hi, I'm talking about the config key like: https://docs.rs/object_store/0.11.1/object_store/aws/enum.AmazonS3ConfigKey.html

I haven't figured out how to use these options to directly build an opendal Operator. I have two thoughts:

  1. Provide an object_store::S3Builder which implements opendal::Builder, allowing users to construct an opendal::Builder using config keys in AmazonS3ConfigKey
  2. Write a helper function to convert AmazonS3Builder into opendal::Builder

Do you have any other ideas ?

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 26, 2024

I'm thinking of an object_store_opendal::AmazonS3Builder that returns object_store_opendal::ObjectStore. It don't need to play with opendal::Builder directly.

@meteorgan
Copy link
Contributor

I'm thinking of an object_store_opendal::AmazonS3Builder that returns object_store_opendal::ObjectStore. It don't need to play with opendal::Builder directly.

Ok. Let me give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants