Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: load endpoint_url from aws config file #5275

Closed
1 task done
TennyZhuang opened this issue Nov 3, 2024 · 3 comments · Fixed by #5279
Closed
1 task done

new feature: load endpoint_url from aws config file #5275

TennyZhuang opened this issue Nov 3, 2024 · 3 comments · Fixed by #5279
Labels
enhancement New feature or request

Comments

@TennyZhuang
Copy link
Contributor

Feature Description

aws config file allows users to customize the endpoint_url from config file or environment.

Problem and Solution

[default]
region = auto
endpoint_url = http://minio.local

The argument will override the endpoint used by AWS CLI. It's preferable for OpenDAL to respect this.

It can also be specified by S3, but we can support it later due to parsing complexity:

[default]
region = auto
services = minio

[services minio]
s3 =
  endpoint_url = http://minio.local

The environment variable AWS_ENDPOINT_URL or AWS_ENDPOINT_URL_S3 can also override the argument.

Additional Context

OpenDAL appears to use the reqsign crate, owned by @Xuanwo, to parse the config file. Should we add the argument support in that crate?

Are you willing to contribute to the development of this feature?

  • Yes, I am willing to contribute to the development of this feature.
@TennyZhuang TennyZhuang added the enhancement New feature or request label Nov 3, 2024
@TennyZhuang
Copy link
Contributor Author

It seems that a reasonable approach is OpenDAL should read and parse the config file itself, since there are many configs unrelated to key signing.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 3, 2024

It seems that a reasonable approach is OpenDAL should read and parse the config file itself, since there are many configs unrelated to key signing.

I prefer incorporate all those scopes into reqsign. By implementing them in reqsign, users who need to interact with AWS services can reuse reqsign without relying on OpenDAL.

endpoint_url is good to be supported. Other S3-specific settings, such as multipart size, might not be applicable because they are intended for s3cmd, and opendal doesn't offer the same semantic to users.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 3, 2024

the reqsign crate, owned by @Xuanwo

This is not good for me. I'm working on donating resign to the ASF instead and will share the updates with the OpenDAL community once it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants