OPENNLP-1671: Convert while loops with duplicated code to do-while loops (#712)

Author: mawiesne

opennlp-tools/src/main/java/opennlp/tools/formats/ad/ADSentenceStream.java

@@ -156,12 +156,9 @@ public Sentence parse(String sentenceString, int para, boolean isTitle, boolean
         sentence.setText(text);
         sentence.setMetadata(meta);
         // now we look for the root node
-
-        // skip lines starting with ###
-        line = reader.readLine();
-        while (line != null && line.startsWith("###")) {
+        do {
           line = reader.readLine();
-        }
+        } while (line != null && line.startsWith("###")); // skip lines starting with ###
 
         // got the root. Add it to the stack
         Stack<Node> nodeStack = new Stack<>();

opennlp-tools/src/main/java/opennlp/tools/sentdetect/DefaultSDContextGenerator.java

@@ -83,7 +83,7 @@ private static String escapeChar(Character c) {
       return "<CR>";
     }
 
-    return new String(new char[]{c});
+    return String.valueOf(c);
   }
 
   @Override
@@ -232,15 +232,15 @@ private static boolean isFirstUpper(String s) {
   /**
    * Finds the index of the nearest space before a specified index which is not itself preceded by a space.
    *
-   * @param sb   The string buffer which contains the text being examined.
+   * @param sb   The {@link CharSequence} which contains the text being examined.
    * @param seek The index to begin searching from.
    * @return The index which contains the nearest space.
    */
   private static int previousSpaceIndex(CharSequence sb, int seek) {
-    seek--;
-    while (seek > 0 && !StringUtil.isWhitespace(sb.charAt(seek))) {
+    do {
       seek--;
-    }
+    } while (seek > 0 && !StringUtil.isWhitespace(sb.charAt(seek)));
+
     if (seek > 0 && StringUtil.isWhitespace(sb.charAt(seek))) {
       while (seek > 0 && StringUtil.isWhitespace(sb.charAt(seek - 1)))
         seek--;
@@ -252,7 +252,7 @@ private static int previousSpaceIndex(CharSequence sb, int seek) {
   /**
    * Finds the index of the nearest space after a specified index.
    *
-   * @param sb The string buffer which contains the text being examined.
+   * @param sb The {@link CharSequence} which contains the text being examined.
    * @param seek The index to begin searching from.
    * @param lastIndex The highest index of the StringBuffer sb.
    * @return The index which contains the nearest space.