Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow different Docker Repos and Credentials to pull Docker Images #4787

Closed
ThomasUllrich666 opened this issue Jan 3, 2020 · 6 comments · Fixed by #4791
Closed

Comments

@ThomasUllrich666
Copy link

Hello I want to use OpenWhisk for a big app in our Company.
Therefore I need a way to pull the image from our internal Docker Artifactory Repository.

Can you please implement a way that solves this problem?

@style95
Copy link
Member

style95 commented Jan 3, 2020

@ThomasUllrich666 Do you want to use a consolidated docker registry for all images or multiple registries for each runtime(blackbox) container?

@ThomasUllrich666
Copy link
Author

If I can choose I would like to have a way to implement multiple registry for different container.
I think that the best way will be that openwhis change the ~/.docker/config.json in a proper way. Then the user is able to add as many repos as he want.

@style95
Copy link
Member

style95 commented Jan 3, 2020

ok this is good to have.

In our downstream repo, we added a volume mapping for ~/.docker/ on all invokers.
I logged in to our private registry and give access to all custom docker images for the docker user.
Then users can create actions with custom docker images from a private registry.
Invokers are also able to pull images from a private registry as long as they have access to the registry and the images.
I haven't tried with multiple registries but I think it would work ideally if you login to all registries.

I would open a pull request for this soon.

@dgrove-oss
Copy link
Member

A related user comment here: apache/openwhisk-deploy-kube#528 (comment)

@acabarbaye
Copy link

acabarbaye commented May 15, 2020

Just for verification, does it mean that this statement in the documentation is no longer true ? https://github.com/apache/openwhisk/blob/master/docs/actions-docker.md#usage

must be an image name for a public Docker image on Docker Hub.

If so, could the documentation be updated in order to understand how to use/configure a private registry?
Moreover, would it work for images located in a AWS ECS instance?

@style95
Copy link
Member

style95 commented May 15, 2020

@acabarbaye Yes, it seems the document should be updated accordingly.

An operator can log-in to a private registry and do volume mapping like this(for a native installation):

invoker_docker_volumes:
  - ~/.docker:/root/.docker

For K8S cluster, you can refer to this: https://github.com/apache/openwhisk-deploy-kube/blob/e53e5ea79d49a6aa92e82c4b81dff82d21db630e/docs/private-docker-registry.md

With regard to images in ECS, I think it would work as long as they are accessible in the same way with the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants