[core] Cleaning snapshots or deleting tags should skip those referenced by branches. #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinMingQiang
force-pushed
the
master-fix-skip-branch-snp-expire
branch
from
11fc94b
to
f935b71
Compare
|
If the snapshot is not deleted here, when will it be cleared? |
@JingsongLi @LinMingQiang Maybe we both need to merge our PRs. |
JingsongLi
reviewed
Jul 24, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileDeletionBase.java
Outdated
Show resolved
Hide resolved
LinMingQiang
changed the title
LinMingQiang
changed the title
LinMingQiang
force-pushed
the
master-fix-skip-branch-snp-expire
branch
7 times, most recently
from
15113ad
to
6d14799
Compare
|
Please rebase master. |
LinMingQiang
force-pushed
the
master-fix-skip-branch-snp-expire
branch
from
6d14799
to
c2f9eda
Compare
done. |
LinMingQiang
force-pushed
the
master-fix-skip-branch-snp-expire
branch
from
9cdfc20
to
c4557ba
Compare
JingsongLi
reviewed
Aug 6, 2024
| } | ||
|
|
||
| public static List<Snapshot> mergeTreeSetToList( | ||
| Collection<Snapshot> set1, Collection<Snapshot> set2) { |
There was a problem hiding this comment.
Where is the tree set?
sortToList?
There was a problem hiding this comment.
Change method name to 'mergeSetToSortedList'
| FileStoreTableFactory.create( | ||
| fileIO, new Path(branchPath(tablePath, branchName))); | ||
| SortedMap<Snapshot, List<String>> snapshotTags = branchTable.tagManager().tags(); | ||
| Snapshot earliestSnapshot = branchTable.snapshotManager().earliestSnapshot(); |
There was a problem hiding this comment.
What is difference betweend branchCreateSnapshot and this earliestSnapshot?
| List<String> tags = snapshotTags.get(snapshot); | ||
| checkArgument(tags.size() == 1); | ||
| sortedSnapshots | ||
| .computeIfAbsent(snapshot, s -> new ArrayList<>()) |
There was a problem hiding this comment.
Why get snapshot from tags?
JingsongLi
reviewed
Aug 6, 2024
|
@LinMingQiang Can we remove this feature? Branches can only be created through tags, or completely new branch (without inheriting data from the main branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Next part for #3808
The purpose of this pr :
The purpose of the branch is to asynchronously recover data and overwrite the main branch
paimon branch . If the recovery operation takes too long, the snapshot referenced by the branch may be expired and deleted, which will make the branch unavailable.
Let's say we created tag1 and branch1 based on snapshot-1, when snapshot-1 expires then the related
manifest filewill be deleted. However ,if themanifest fileis referenced by the some tag, it will not be cleaned up.But if the
manifest fileis still referenced by branch-1, it will still be cleaned, this led to query branch1 will throwmanifets filenot found exception.Solution :
1: Skip cleanup : Merge snapshots referenced by branch or tag in the code of
ExpireSnapshotsImpl#expireUntilthen skip the files associated with these snapshots.2: When to clean : Referring to the logic of
delete tag, when we delete the branch, we also clean up the expired snapshot files (manifest files and data files).3: delete tag/branch : Now, when deleting a tag or branch, we need to consider whether the snapshot involved is still referenced by other tags/branches.
Linked issue: close #xxx
Tests
API and Format
TagManager#deleteTag: Add logical , whether the snapshot is referenced by other branch, if so, thedoCleanof the snapshot should be skipped.BranchManager#deleteBranch: Add logical , If the snapshot has expired and is not referenced by another branch or tag, triggerdoCleanto delete manifest&data file.Documentation