-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][core] Implement more type conversions for IcebergConversions #3788
Comments
I'm willing to submit a PR! |
Do this according to the following specifications? then,like this: case TIME: |
Thanks for your interest. Please note that there are two types of timestamp in Paimon: All in all you need to write tests carefully, especially for timestamp. |
I want to be simple |
The Paimon object for For Also you need to check if Don't forget to add complete tests for each timestamp type and different precisions. |
Just give me a little time. I have to fix it |
"local-timestamp-micros" is not a data type in Paimon. It is a data type in avro. Iceberg's avro reader has to deal with it. However for this issue, you only need to convert between Paimon types and Iceberg types, so you don't need to consider about avro types. |
@tsreaper Can I submit PR? |
Sure, feel free to submit. |
@tsreaper Please help to review my pr, thank you very much |
@tsreaper |
Search before asking
Motivation
In #3731 we've introduced
IcebergCommitCallback
to create Iceberg metadata after commit. We convert Paimon objects to Iceberg byte buffers inIcebergConversions
, however it currently only supports a few types and does not support types like timestamp and time.Solution
Support timestamp and time conversions in
IcebergConversions
.Anything else?
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: