[core] Support rename tag action and procedure #4277
Conversation
xuzifu666
changed the title
| <td> | ||
| CALL sys.rename_tag(table => 'default.T', tag_name => 'tag1', new_tag_name => 'tag2') | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
target_name will be better ?
| try { | ||
| if (!tagExists(tagName)) { | ||
| throw new RuntimeException(String.format("tag: %s is not exists", tagName)); | ||
| } |
There was a problem hiding this comment.
The specified tag name [%s] does not exist ?
| import java.util.Optional; | ||
|
|
||
| /** Factory to create {@link RenameActionFactory}. */ | ||
| public class RenameActionFactory implements ActionFactory { |
There was a problem hiding this comment.
RenameTagActionFactory ?
| public void run() throws Exception { | ||
| if (StringUtils.isEmpty(tagName) || StringUtils.isEmpty(newTagName)) { | ||
| throw new RuntimeException(String.format("tagName or newTagName can not be empty")); | ||
| } |
There was a problem hiding this comment.
String.format("The specified tag name [%s] or target tag name [%s] cannot be empty.", tagName, targetName)
| throws Catalog.TableNotExistException { | ||
| Table table = catalog.getTable(Identifier.fromString(tableId)); | ||
| table.renameTag(tagName, newTagName); | ||
| return new String[] {"Success"}; |
There was a problem hiding this comment.
return : Rename [%s] to [%s] successfully .
|
Thanks for @LinMingQiang review. Had addressed comments. |
|
+1 |
docs/content/spark/procedures.md
Outdated
| <tr> | ||
| <td>rename_tag</td> | ||
| <td> | ||
| Rename tag to new tag name. Arguments: |
There was a problem hiding this comment.
Rename a tag with a new tag name.
docs/content/spark/procedures.md
Outdated
| <tr> | ||
| <td>rename_tag</td> | ||
| <td> | ||
| Rename tag to new tag name. Arguments: |
There was a problem hiding this comment.
Rename a tag with a new tag name.
| import java.util.Optional; | ||
|
|
||
| /** Factory to create {@link RenameActionTagFactory}. */ | ||
| public class RenameActionTagFactory implements ActionFactory { |
There was a problem hiding this comment.
RenameTagActionFactory?
| /** Factory to create {@link RenameActionTagFactory}. */ | ||
| public class RenameActionTagFactory implements ActionFactory { | ||
|
|
||
| public static final String IDENTIFIER = "rename_tag"; |
|
|
||
| @Override | ||
| public void printHelp() { | ||
| System.out.println("Action \"rename_tag\" rename a tag with a new tagname."); |
There was a problem hiding this comment.
Typo: In word 'tagname'
| import org.apache.flink.table.procedure.ProcedureContext; | ||
|
|
||
| /** | ||
| * Create tag procedure. Usage: |
| argument = { | ||
| @ArgumentHint(name = "table", type = @DataTypeHint("STRING")), | ||
| @ArgumentHint(name = "tagName", type = @DataTypeHint("STRING")), | ||
| @ArgumentHint(name = "targetTagName", type = @DataTypeHint("STRING")) |
| * </code></pre> | ||
| */ | ||
| public class RenameTagProcedure extends ProcedureBase { | ||
| public static final String IDENTIFIER = "rename_tag"; |
docs/content/spark/procedures.md
Outdated
| Rename tag to new tag name. Arguments: | ||
| <li>table: the target table identifier. Cannot be empty.</li> | ||
| <li>tag_name: name of the tag. Cannot be empty.</li> | ||
| <li>target_tag_name: the new tag name to rename.</li> |
There was a problem hiding this comment.
target_tag_name: the new tag name to rename. Cannot be empty.
|
Why you need this feature? |
|
Change title to :"Support rename tag action and procedure."; |
Yes, if user want to modify tag name which was not normative need the feature. Currently user cannot rename tag in a direct way, and if snapshot expire user cannot rename tag any more. @wwj6591812 |
xuzifu666
changed the title
|
Thanks for @wwj6591812 review, had addressed comments. |
|
+1 |
Purpose
Currently tag can not rename after create，this pr is aim to support it.
Linked issue: close #xxx
Tests
API and Format
Documentation