PARQUET-1093: Improve Arrow level generation error message

xhochy · wesm · commit 15f9839d9632 · 2017-09-11T11:15:46.000-04:00
Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes #390 from xhochy/PARQUET-1093 and squashes the following commits: 433e391 [Korn, Uwe] PARQUET-1093: Improve Arrow level generation error message
diff --git a/src/parquet/arrow/writer.cc b/src/parquet/arrow/writer.cc
@@ -91,10 +91,10 @@ class LevelBuilder {
     return VisitInline(*array.values());
   }
 
-#define NOT_IMPLEMENTED_VISIT(ArrowTypePrefix)                     \
-  Status Visit(const ::arrow::ArrowTypePrefix##Array& array) {     \
-    return Status::NotImplemented(                                 \
-        "Level generation for ArrowTypePrefix not supported yet"); \
+#define NOT_IMPLEMENTED_VISIT(ArrowTypePrefix)                             \
+  Status Visit(const ::arrow::ArrowTypePrefix##Array& array) {             \
+    return Status::NotImplemented("Level generation for " #ArrowTypePrefix \
+                                  " not supported yet");                   \
   }
 
   NOT_IMPLEMENTED_VISIT(Struct)

Original file line number	Diff line number	Diff line change
`@@ -91,10 +91,10 @@ class LevelBuilder {`
`91`	`91`	`return VisitInline(*array.values());`
`92`	`92`	`}`
`93`	`93`
`94`		`-#define NOT_IMPLEMENTED_VISIT(ArrowTypePrefix) \`
`95`		`- Status Visit(const ::arrow::ArrowTypePrefix##Array& array) { \`
`96`		`- return Status::NotImplemented( \`
`97`		`- "Level generation for ArrowTypePrefix not supported yet"); \`
	`94`	`+#define NOT_IMPLEMENTED_VISIT(ArrowTypePrefix) \`
	`95`	`+ Status Visit(const ::arrow::ArrowTypePrefix##Array& array) { \`
	`96`	`+ return Status::NotImplemented("Level generation for " #ArrowTypePrefix \`
	`97`	`+ " not supported yet"); \`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`NOT_IMPLEMENTED_VISIT(Struct)`