Skip to content

Commit 1fa93b1

Browse files
author
Piyush Narang
committed
Log values writer factory chosen
1 parent ad511be commit 1fa93b1

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,10 @@ public int getMaxRowCountForPageSizeCheck() {
181181
return maxRowCountForPageSizeCheck;
182182
}
183183

184+
public ValuesWriterFactory getValuesWriterFactory() {
185+
return valuesWriterFactory;
186+
}
187+
184188
public boolean estimateNextSizeCheck() {
185189
return estimateNextSizeCheck;
186190
}

parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@ public static ValuesWriterFactory getValuesWriterFactory(Configuration conf) {
335335
Class<? extends ValuesWriterFactory> factoryOverride =
336336
(Class<? extends ValuesWriterFactory>) ConfigurationUtil.getClassFromConfig(conf, WRITER_FACTORY_OVERRIDE, ValuesWriterFactory.class);
337337
if (factoryOverride == null) {
338+
// no override specified, fall back to default
338339
factoryOverride = ParquetProperties.DEFAULT_VALUES_WRITER_FACTORY;
339340
}
340341

@@ -413,6 +414,7 @@ public RecordWriter<Void, T> getRecordWriter(Configuration conf, Path file, Comp
413414
LOG.info("Page size checking is: " + (props.estimateNextSizeCheck() ? "estimated" : "constant"));
414415
LOG.info("Min row count for page size check is: " + props.getMinRowCountForPageSizeCheck());
415416
LOG.info("Max row count for page size check is: " + props.getMaxRowCountForPageSizeCheck());
417+
LOG.info("ValueWriterFactory chosen is: " + props.getValuesWriterFactory());
416418
}
417419

418420
WriteContext init = writeSupport.init(conf);

0 commit comments

Comments
 (0)