Skip to content

Commit 62388c1

Browse files
author
Andrew Duffy
committed
Fixup incorrect usages of checkNotNull
1 parent 0b0fe10 commit 62388c1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@ public static final class Eq<T extends Comparable<T>> extends ColumnFilterPredic
185185

186186
// value can be null
187187
Eq(Column<T> column, T value) {
188-
super(column, value);
188+
super(column, checkNotNull(value, "value"));
189189
}
190190

191191
// value can be null
192192
Eq(Column<T> column, T value, ByteSignedness signedness) {
193-
super(column, value, signedness);
193+
super(column, checkNotNull(value, "value"), signedness);
194194
}
195195

196196
@Override
@@ -204,12 +204,12 @@ public static final class NotEq<T extends Comparable<T>> extends ColumnFilterPre
204204

205205
// value can be null
206206
NotEq(Column<T> column, T value) {
207-
super(column, value);
207+
super(column, checkNotNull(value, "value"));
208208
}
209209

210210
// value can be null
211211
NotEq(Column<T> column, T value, ByteSignedness signedness) {
212-
super(column, value, signedness);
212+
super(column, checkNotNull(value, "value"), signedness);
213213
}
214214

215215

@@ -224,7 +224,7 @@ public static final class Lt<T extends Comparable<T>> extends ColumnFilterPredic
224224

225225
// value cannot be null
226226
Lt(Column<T> column, T value) {
227-
super(column, value);
227+
super(column, checkNotNull(value, "value"));
228228
}
229229

230230
// value cannot be null

parquet-hadoop/src/main/java/org/apache/parquet/filter2/statisticslevel/StatisticsFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public class StatisticsFilter implements FilterPredicate.Visitor<Boolean> {
6868
private static final boolean BLOCK_CANNOT_MATCH = true;
6969

7070
public static boolean canDrop(FilterPredicate pred, List<ColumnChunkMetaData> columns) {
71-
checkNotNull(pred, "predicate cannot be null");
72-
checkNotNull(columns, "columns cannot be null");
71+
checkNotNull(pred, "pred");
72+
checkNotNull(columns, "columns");
7373
return pred.accept(new StatisticsFilter(columns));
7474
}
7575

0 commit comments

Comments
 (0)