Skip to content

Commit a382668

Browse files
committed
PARQUET-540: Fix Cascading 3 build thrift and SLF4J.
1 parent 944291b commit a382668

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

parquet-cascading3/pom.xml

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,33 @@
5151
<version>${project.version}</version>
5252
</dependency>
5353
<dependency>
54-
<groupId>org.apache.parquet</groupId>
55-
<artifactId>parquet-thrift</artifactId>
56-
<version>${project.version}</version>
54+
<groupId>org.apache.parquet</groupId>
55+
<artifactId>parquet-thrift</artifactId>
56+
<version>${project.version}</version>
57+
</dependency>
58+
<dependency>
59+
<groupId>org.slf4j</groupId>
60+
<artifactId>slf4j-api</artifactId>
61+
<version>${slf4j.version}</version>
5762
</dependency>
5863
<dependency>
5964
<groupId>org.apache.hadoop</groupId>
6065
<artifactId>hadoop-client</artifactId>
6166
<version>${hadoop.version}</version>
6267
<scope>provided</scope>
6368
</dependency>
69+
<dependency>
70+
<groupId>org.apache.thrift</groupId>
71+
<artifactId>libthrift</artifactId>
72+
<version>${thrift.version}</version>
73+
<scope>provided</scope>
74+
</dependency>
75+
<dependency>
76+
<groupId>cascading</groupId>
77+
<artifactId>cascading-hadoop</artifactId> <!-- building against cascading-hadoop for Hadoop1, but will use against any backend -->
78+
<version>${cascading3.version}</version>
79+
<scope>provided</scope>
80+
</dependency>
6481
<dependency>
6582
<groupId>org.apache.parquet</groupId>
6683
<artifactId>parquet-column</artifactId>
@@ -75,10 +92,10 @@
7592
<scope>test</scope>
7693
</dependency>
7794
<dependency>
78-
<groupId>cascading</groupId>
79-
<artifactId>cascading-hadoop</artifactId> <!-- building against cascading-hadoop for Hadoop1, but will use against any backend -->
80-
<version>${cascading3.version}</version>
81-
<scope>provided</scope>
95+
<groupId>org.slf4j</groupId>
96+
<artifactId>slf4j-simple</artifactId>
97+
<version>${slf4j.version}</version>
98+
<scope>test</scope>
8299
</dependency>
83100
</dependencies>
84101

pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,6 @@
5757
</developer>
5858
</developers>
5959

60-
<!-- this is needed for maven-thrift-plugin, would like to remove this.
61-
see: https://issues.apache.org/jira/browse/THRIFT-1536 -->
62-
<pluginRepositories>
63-
<pluginRepository>
64-
<id>Twitter public Maven repo</id>
65-
<url>http://maven.twttr.com</url>
66-
</pluginRepository>
67-
</pluginRepositories>
68-
6960
<properties>
7061
<targetJavaVersion>1.6</targetJavaVersion>
7162
<maven.compiler.source>1.6</maven.compiler.source>

0 commit comments

Comments
 (0)