Skip to content

Commit d6e77ad

Browse files
committed
PARQUET-212: Rename isElementType => isListElementType.
1 parent 4d9afd1 commit d6e77ad

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.List;
2525
import java.util.Map;
2626

27-
import org.apache.hadoop.conf.Configurable;
2827
import org.apache.hadoop.conf.Configuration;
2928
import org.apache.thrift.TException;
3029
import org.apache.thrift.protocol.TField;
@@ -662,7 +661,7 @@ abstract class CollectionConverter extends GroupConverter {
662661
}
663662
Type repeatedType = parquetSchema.getType(0);
664663
valuesType = values.getType().getType();
665-
if (ThriftSchemaConverter.isElementType(repeatedType, values)) {
664+
if (ThriftSchemaConverter.isListElementType(repeatedType, values)) {
666665
if (repeatedType.isPrimitive()) {
667666
PrimitiveCounter counter = new PrimitiveCounter(newConverter(listEvents, repeatedType, values).asPrimitiveConverter());
668667
child = counter;

parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConverter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ private static StructType toStructType(TStructDescriptor struct) {
100100
* @param thriftElement the expected Schema for list elements
101101
* @return {@code true} if the repeatedType is the element schema
102102
*/
103-
static boolean isElementType(Type repeatedType, ThriftField thriftElement) {
103+
static boolean isListElementType(Type repeatedType,
104+
ThriftField thriftElement) {
104105
if (repeatedType.isPrimitive() ||
105106
(repeatedType.asGroupType().getFieldCount() != 1)) {
106107
// The repeated type must be the element type because it is an invalid

0 commit comments

Comments
 (0)