PARQUET-253: Fixes Javadoc of AvroSchemaConverter#173
Closed
liancheng wants to merge 1 commit intoapache:masterfrom
Closed
PARQUET-253: Fixes Javadoc of AvroSchemaConverter#173liancheng wants to merge 1 commit intoapache:masterfrom
liancheng wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@liancheng could you open an issue for this and update the PR title? We use the Spark script and only merge PRs with a JIRA ID in the title: "PARQUET-XYZ: Fixes Javadoc..." Thanks! |
liancheng
changed the title
Contributor
Author
|
@rdblue Done. Didn't realize Parquet is more strict than Spark, JIRA ticket is optional there when merging minor PRs :) |
Contributor
|
Thanks for fixing that! Unfortunately because of the org.apache rename, I can't merge this unless you rebase. Thanks! |
Contributor
|
@liancheng could you rebase this? It isn't passing the merge script. |
Contributor
|
Nevermind. It looks like the script was lying and I could merge it. It just had to resort to a 3-way merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got confused by the original Javadoc at first and didn't realize
AvroSchemaConverteris also capable to convert a Parquet schema to an Avro schema.