PARQUET-152: Add validation on Encoding.DELTA_BYTE_ARRAY to allow FIX…#225
Closed
spena wants to merge 1 commit intoapache:masterfrom
spena:parquet-152
Closed
PARQUET-152: Add validation on Encoding.DELTA_BYTE_ARRAY to allow FIX…#225spena wants to merge 1 commit intoapache:masterfrom spena:parquet-152
spena wants to merge 1 commit intoapache:masterfrom
spena:parquet-152
Conversation
…ED_LEN_BYTE_ARRAY types.
* FIXED_LEN_BYTE_ARRAY types are binary values thay may use DELTA_BYTE_ARRAY encoding,
so they should be allowed to be decoded using the same DELTA_BYTE_ARRAY encoding.
Contributor
Author
|
ParquetProperties.writerToFallbackTo() shows that only BINARY and FIXED_LEN_BYTE_ARRAY are supported for DELTA_BYTE_ARRAY: |
Contributor
|
Looks good to me. I don't think anything else should use DELTA_BYTE_ARRAY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARQUET-152: Add validation on Encoding.DELTA_BYTE_ARRAY to allow FIXED_LEN_BYTE_ARRAY types.
so they should be allowed to be decoded using the same DELTA_BYTE_ARRAY encoding.
@rdblue @nezihyigitbasi Could you review this fix?
I executed a test by writing a file that fall backs to DELTA_BYTE_ARRAY encoding, then read the file, and compare the read values with the written values, and it worked fine.