PARQUET-320: Fix semver problems for parquet-hadoop. #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1, thanks. Sorry, a lot of that was me "cleaning things up" I think some of these classes might be considered private / internal, but we can make that distinction more clear in 2.0. |
The TypeVisitor was changed to a parameterized class with a return type and a state type. This was an incompatible change, so the fix is to restore the TypeVistor class and add a second class with the type parameters, StateVisitor. Implementations are safe to update to the new interface because they are internal. ComplexTypeVisitor was also restored. Both TypeVisitor and ComplexTypeVisitor are now deprecated. ThriftSchemaConvertVisitor was public but should not have been and is now package-private. This required a semver exception in the POM.
rdblue
force-pushed
the
PARQUET-320-fix-semver-issues
branch
from
95578d4 to
a0e730d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables semver checks for Parquet packages by removing the parquet/** exclusion that was matching unexpected classes. This also fixes all of the semver problems that have been committed since the check started excluding all Parquet classes.